-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: update DEVELOPMENT.md #455
Conversation
bd4abf2
to
dd041e7
Compare
@airkei Thank you for the PR! 👍 Currently we are using ansible to setup the system and install otaclient. But that ansible playbook, as you know, is not public, so we cannot just copy-paste it to this repository. Actually I think currently we should just completely remove this doc. |
@Bodong-Yang Thank you for feedback. As you say, we should not describe the instructions which depends on non-public setup. On the other hand, I think it's better to describe the instructions as much as possible in markdown. |
I think this strategy is OK for now 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's remove the installation part for now. 👍
In the future we can either provide a full and detailed guide of setting up device system and otaclient, or even provide a stripped down version of otaclient installation role.
1ceee95
to
fdd7ac8
Compare
Quality Gate passedIssues Measures |
commit b4b9547 Author: bodong.yang <[email protected]> Date: Wed Dec 18 07:51:29 2024 +0000 ota_core: wait on any_child_ecu_in_update not set commit 1fd8994 Author: bodong.yang <[email protected]> Date: Wed Dec 18 07:35:21 2024 +0000 minor fix commit 276deff Author: bodong.yang <[email protected]> Date: Wed Dec 18 07:33:38 2024 +0000 fix up test_ecu_status commit 2f5d322 Author: bodong.yang <[email protected]> Date: Wed Dec 18 07:22:29 2024 +0000 fix up test_ecu_status commit 7a57a6f Author: bodong.yang <[email protected]> Date: Wed Dec 18 07:11:40 2024 +0000 ecu_status: set ecu_status_flags.any_child_ecu_in_update accordingly commit 1ac7cc9 Author: bodong.yang <[email protected]> Date: Wed Dec 18 07:08:32 2024 +0000 otaclient.main: MultipleECUStatusFlags: rename any_in_update to any_child_ecu_in_update commit f19560c Author: bodong.yang <[email protected]> Date: Wed Dec 18 07:08:11 2024 +0000 otaclient._types: MultipleECUStatusFlags: rename any_in_update to any_child_ecu_in_update commit 3d05444 Author: Keisuke Nakata <[email protected]> Date: Tue Dec 17 10:21:54 2024 +0900 docs: update DEVELOPMENT.md (#455) update DEVELOPMENT.md commit b710bb0 Author: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Date: Tue Dec 17 09:53:24 2024 +0900 build(deps): Update uvicorn[standard] requirement (#457) Updates the requirements on [uvicorn[standard]](https://github.com/encode/uvicorn) to permit the latest version. - [Release notes](https://github.com/encode/uvicorn/releases) - [Changelog](https://github.com/encode/uvicorn/blob/master/CHANGELOG.md) - [Commits](encode/uvicorn@0.30.0...0.34.0) --- updated-dependencies: - dependency-name: uvicorn[standard] dependency-type: direct:production ... Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> commit 3ffaf90 Author: Bodong Yang <[email protected]> Date: Mon Dec 16 15:30:09 2024 +0900 feat: deps: bump to use simple-sqlite3-orm v0.5.0, update the otaproxy accordingly (#454) This PR bumps to use simple-sqlite3-orm v0.5.0 for otaproxy, and updates the otaproxy accordingly. Also missing indexes for ota_cache metadata db (previously defined before otaclient v3.7.1) are added back to otaproxy. Other minor changes: 1. lru_cache_helper: use burst_suppressed_logger for loggings that might be flooded.
Why
docs/
directory is no more used, but the instructions inDEVELOPMENT.md
still refer docs directory.What
Update
DEVELOPMENT.md
to describe the current procedure.