chore(pacmod_interface): separate pacmod callback #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: tomoya.kimura <[email protected]>
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #68 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 11 11
Lines 959 981 +22
=====================================
- Misses 959 981 +22
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@tkimura4 Oh,,, I missed this PR, shall I review this? |
|
@shmpwk |
zusizusi
added a commit
that referenced
this pull request
Jul 4, 2024
This reverts commit b779f84. Signed-off-by: Sho Iwasawa <[email protected]>
zusizusi
added a commit
that referenced
this pull request
Jul 4, 2024
…acmod callback (#68)" (#83) * Revert "chore(pacmod_interface): separate pacmod callback (#68)" This reverts commit b779f84. Signed-off-by: Sho Iwasawa <[email protected]> * style(pre-commit): autofix * fix type Signed-off-by: Sho Iwasawa <[email protected]> --------- Signed-off-by: Sho Iwasawa <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Depending on the firmware version of Pacmod, messages from Pacmod (rpt messages) are published at different timings and intervals. Therefore, it is inappropriate to synchronize and subscribe to all rpt messages using a message filter.
In this pull request , we have made changes to individually subscribe to each rpt message without using a message filter.