Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor(global_parameter_loader): prefix package and namespace with autoware #87

Merged
merged 1 commit into from
Dec 4, 2024

Conversation

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 0.00%. Comparing base (b779f84) to head (0a60a84).
Report is 7 commits behind head on main.

Additional details and impacted files
@@          Coverage Diff           @@
##            main     #87    +/-   ##
======================================
  Coverage   0.00%   0.00%            
======================================
  Files         11      11            
  Lines        981     960    -21     
  Branches       0     101   +101     
======================================
+ Misses       981     960    -21     
Flag Coverage Δ
differential 0.00% <ø> (?)
total ?

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.


🚨 Try these New Features:

Copy link
Contributor

@mitsudome-r mitsudome-r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but this has to be merged with all the other relevant PRs.

@xmfcx
Copy link

xmfcx commented Dec 4, 2024

See my review here:

This should be merged ASAP since the others are merged already.

@mitsudome-r 🚨

@mitsudome-r mitsudome-r merged commit 1c033a2 into tier4:main Dec 4, 2024
8 checks passed
@esteve esteve deleted the prefix-global_parameter_loader branch December 4, 2024 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants