Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update flake8 version from 6.0.0 to 6.1.0 #103

Merged
merged 1 commit into from
Jul 5, 2024

Conversation

xmfcx
Copy link
Contributor

@xmfcx xmfcx commented Jul 5, 2024

This change is already done in https://github.com/tier4/pre-commit-hooks-ros/releases/tag/v0.9.0 but it is not in the main branch for some reason.

This is causing problems here:

.github/update-sync-param-files.py:14:19: E231 missing whitespace after ':'
REPO_URL = f"https://github.com/{REPO_NAME}.git"
                  ^
1     E231 missing whitespace after ':'

And solution is to switch to flake8 6.1 as stated in this post: https://stackoverflow.com/questions/77527580/pre-commit-throwing-errors-on-missing-whitespace-after

And let's do another release (v0.10.0) with this commit.

cc. @SakodaShintaro

@xmfcx xmfcx force-pushed the chore/update-flake8 branch from 10d2e44 to 153bc1d Compare July 5, 2024 11:23
Copy link
Contributor

@SakodaShintaro SakodaShintaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I should have not only created tag v0.9.0, but also made a PR to push the main branch. That was my mistake.
Thank you!
LGTM

@SakodaShintaro SakodaShintaro merged commit eb39301 into tier4:main Jul 5, 2024
7 checks passed
@xmfcx xmfcx deleted the chore/update-flake8 branch July 5, 2024 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants