Skip to content

Commit

Permalink
change to the method of determining powers of 2 using bitwise operations
Browse files Browse the repository at this point in the history
Signed-off-by: yamasaki <[email protected]>
  • Loading branch information
ymski committed Oct 4, 2023
1 parent f4eca4d commit 0359359
Showing 1 changed file with 2 additions and 3 deletions.
5 changes: 2 additions & 3 deletions ros2caret/verb/record.py
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,6 @@
# See the License for the specific language governing permissions and
# limitations under the License.

import math
import os

from typing import Optional
Expand Down Expand Up @@ -190,15 +189,15 @@ def main(self, *, args):
and args.subbuffer_size_ust != 8*4096:
raise ValueError('the --subbuffer-size-ust option is '
'available in iron or rolling')
if not math.log2(args.subbuffer_size_ust).is_integer():
if args.subbuffer_size_ust & (args.subbuffer_size_ust-1):
raise ValueError('--subbuffer-size-ust value must be power of two.')
init_args['subbuffer_size_ust'] = args.subbuffer_size_ust

if os.environ['ROS_DISTRO'] not in ['iron', 'rolling'] \
and args.subbuffer_size_kernel != 32*4096:
raise ValueError('the --subbuffer-size-kernel option is '
'available in iron or rolling')
if not math.log2(args.subbuffer_size_kernel).is_integer():
if args.subbuffer_size_kernel & (args.subbuffer_size_kernel-1):
raise ValueError('--subbuffer-size-kernel value must be power of two.')
init_args['subbuffer_size_kernel'] = args.subbuffer_size_kernel
init(**init_args)
Expand Down

0 comments on commit 0359359

Please sign in to comment.