Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add option for record start immediately #123

Merged
merged 1 commit into from
Oct 11, 2023

Conversation

ymski
Copy link
Contributor

@ymski ymski commented Oct 5, 2023

Description

This PR adds option for recording immediately.
If the immediately option is True, the recording starts without waiting for the user to press Enter when the measurement starts.

usage:

ros2 caret record --immediate

Related links

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR has been properly tested.
  • The PR has been reviewed.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@ymski ymski changed the title feat: add option for record start immidiately feat: add option for record start immediately Oct 5, 2023
@ymski ymski requested a review from isp-uetsuki October 5, 2023 09:01
Copy link
Contributor

@isp-uetsuki isp-uetsuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ymski ymski merged commit d60eebd into tier4:main Oct 11, 2023
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants