Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add record-clock option #125

Merged
merged 8 commits into from
Oct 23, 2023
Merged

feat: add record-clock option #125

merged 8 commits into from
Oct 23, 2023

Conversation

atsushi421
Copy link
Contributor

@atsushi421 atsushi421 commented Oct 12, 2023 •
edited by xygyo77
Loading

Description

This PR adds the --record-clock option for launching the node where the /clock topic is stored to use ROS time.

Related links

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR has been properly tested.
  • The PR has been reviewed.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@atsushi421 atsushi421 marked this pull request as ready for review October 17, 2023 23:19
@nabetetsu nabetetsu requested a review from isp-uetsuki October 18, 2023 01:02
@isp-uetsuki isp-uetsuki requested a review from ymski October 18, 2023 01:23
@atsushi421 atsushi421 mentioned this pull request Oct 18, 2023
Merged
5 tasks
ymski
ymski reviewed Oct 18, 2023
View reviewed changes
ros2caret/verb/record.py Outdated Show resolved Hide resolved
@atsushi421 atsushi421 requested a review from ymski October 18, 2023 10:18
ymski
ymski approved these changes Oct 19, 2023
View reviewed changes
Copy link
Contributor

@ymski ymski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@isp-uetsuki isp-uetsuki requested a review from xygyo77 October 19, 2023 09:38
xygyo77
xygyo77 approved these changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@xygyo77 xygyo77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • Before applying PR
  • PR applied: without "--record-clock" option
  • PR applied: with "--record-clock" option
    In the above cases, we measured the logging simulator caret and visually confirmed that there was no noticeable change in the respective message flows.

@isp-uetsuki isp-uetsuki removed their request for review October 23, 2023 01:25
@atsushi421 atsushi421 merged commit 689de41 into main Oct 23, 2023
8 checks passed
@atsushi421 atsushi421 deleted the clock_recorder_option branch October 23, 2023 07:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ymski ymski ymski approved these changes

@xygyo77 xygyo77 xygyo77 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@atsushi421 @xygyo77 @ymski