Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: remove -d for ros2 caret command #129

Merged
merged 4 commits into from
Oct 27, 2023
Merged

refactor: remove -d for ros2 caret command #129

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
8c41baa
refactor: remove -d from ros2 caret command
bopeng-saitama Oct 23, 2023
e33b93e
fix: flake8 error
bopeng-saitama Oct 23, 2023
3b9be9d
Merge branch 'tier4:main' into ros2-caret-command
bopeng-saitama Oct 26, 2023
bf20e5e
refactor: remove -w for ros2 caret command
bopeng-saitama Oct 26, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 2 additions & 4 deletions ros2caret/verb/check_ctf.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,10 +26,8 @@ class CheckCTFVerb(VerbExtension):

def add_arguments(self, parser, cli_name):
parser.add_argument(
'-d', '--trace_dir', dest='trace_dir', type=str,
help='the path to the trace directory to be checked',
required=True
)
'trace_dir', type=str,
help='the path to the trace directory to be checked')

def main(self, *, args):
try:
Expand Down
6 changes: 2 additions & 4 deletions ros2caret/verb/node_summary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,11 +20,9 @@
class NodeSummaryVerb(VerbExtension):

def add_arguments(self, parser, cli_name):
# NOTE: It looks good to remove '-d', '--trace_dir',
# since the argument is required.
parser.add_argument(
'-d', '--trace_dir', dest='trace_dir', type=str,
help='the path to the trace directory', required=True
'trace_dir', type=str,
help='the path to the trace directory'
)
parser.add_argument(
'--duration_filter', dest='d_filter_args',
Expand Down
4 changes: 2 additions & 2 deletions ros2caret/verb/topic_summary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ class TopicSummaryVerb(VerbExtension):

def add_arguments(self, parser, cli_name):
parser.add_argument(
'-d', '--trace_dir', dest='trace_dir', type=str,
help='the path to the trace directory', required=True
'trace_dir', type=str,
help='the path to the trace directory'
)
parser.add_argument(
'--duration_filter', dest='d_filter_args',
Expand Down
4 changes: 2 additions & 2 deletions ros2caret/verb/trace_point_summary.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,8 +21,8 @@ class TracePointSummaryVerb(VerbExtension):

def add_arguments(self, parser, cli_name):
parser.add_argument(
'-d', '--trace_dir', dest='trace_dir', type=str,
help='the path to the trace directory', required=True
'trace_dir', type=str,
help='the path to the trace directory'
)
parser.add_argument(
'--duration_filter', dest='d_filter_args',
Expand Down