fix(check_caret_rclcpp): skip check_caret_rclcpp for ROS Distributions after iron #135
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s after iron Signed-off-by: ymski <[email protected]>
ymski
force-pushed
the
fix/check_caret_rclcpp_for_iron
branch
from
dce9a8c to
5d97234
Compare
Signed-off-by: ymski <[email protected]>
Signed-off-by: ymski <[email protected]>
Signed-off-by: ymski <[email protected]>
Signed-off-by: ymski <[email protected]>
isp-uetsuki
requested changes
Dec 22, 2023
Signed-off-by: ymski <[email protected]>
Signed-off-by: ymski <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
In humble, application is need to rebuild with caret-rclcpp when traceing and evaluating the data.
After iron some trace points have been added to the ros2-caret, therefore it is no longer necessary to check if you are building with caret-rclcpp.
If a build validation command
ros2 caret check_caret_rclcppis performed, the process is skipped and and exit successfully.Related links
Notes for reviewers
Pre-review checklist for the PR author
In-review checklist for the PR reviewers
The PR reviewers must check the checkboxes below before approval.
Post-review checklist for the PR author
The PR author must check the checkboxes below before merging.
After all checkboxes are checked, anyone who has write access can merge the PR.