Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor: change the version management method #168

Closed
wants to merge 2 commits into from

Conversation

h-suzuki-isp
Copy link
Contributor

@h-suzuki-isp h-suzuki-isp commented Feb 1, 2024

Description

The version of setup.py used to refer to version.py, but modified to write directly to setup.py.
And modified ros2 caret version command.

Related links

Notes for reviewers

Pre-review checklist for the PR author

In-review checklist for the PR reviewers

The PR reviewers must check the checkboxes below before approval.

  • The PR has been properly tested.
  • The PR has been reviewed.

Post-review checklist for the PR author

The PR author must check the checkboxes below before merging.

  • There are no open discussions or they are tracked via tickets.
  • The PR is ready for merge.

After all checkboxes are checked, anyone who has write access can merge the PR.

@h-suzuki-isp h-suzuki-isp requested a review from ymski February 1, 2024 06:47
@h-suzuki-isp h-suzuki-isp changed the title refactor: change method of get version refactor: change the version management method Feb 1, 2024
@h-suzuki-isp
Copy link
Contributor Author

h-suzuki-isp commented Feb 2, 2024

Because I want to use main branch,close this PR and I create new one .
It is PR169.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant