Remove unused function and update comment

tier4 · Dec 10, 2024 · 547cb0a · 547cb0a
1 parent 80c5c89
commit 547cb0a
Show file tree

Hide file tree

Showing 2 changed files with 1 addition and 2 deletions.
diff --git a/...r/include/simple_sensor_simulator/sensor_simulation/detection_sensor/detection_sensor.hpp b/...r/include/simple_sensor_simulator/sensor_simulation/detection_sensor/detection_sensor.hpp
@@ -68,7 +68,6 @@ class DetectionSensorBase
 private:
   std::optional<math::geometry::Plane> ego_plane_opt_;
   std::optional<geometry_msgs::msg::Pose> ego_plane_pose_opt_;
-  auto hasEgoOrientationChanged() const -> bool;
 };
 
 template <typename T, typename U = autoware_perception_msgs::msg::TrackedObjects>

diff --git a/...ation/simple_sensor_simulator/src/sensor_simulation/detection_sensor/detection_sensor.cpp b/...ation/simple_sensor_simulator/src/sensor_simulation/detection_sensor/detection_sensor.cpp
@@ -89,7 +89,7 @@ auto DetectionSensorBase::isOnOrAboveEgoPlane(
              ego_pose_ros.orientation, ego_plane_pose_opt_->orientation) > rotation_threshold_;
   };
 
-  // if other entity is just above ego return true
+  // if other entity is at the same altitude as Ego or within max_downward_z_offset_ below Ego
   if (entity_pose.position().z() >= (ego_pose.position().z() - max_downward_z_offset_)) {
     return true;
     // otherwise check if other entity is above ego plane