Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add PseudoTrafficSignalDetectorConfidenceSetAction@v1 #1111

Merged
merged 19 commits into from
Nov 8, 2023
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
19 commits
Select commit Hold shift + click to select a range
7efa2f3
feat(traffic_simulator): add confidence to Bulb class
HansRobo Oct 16, 2023
b024972
Merge remote-tracking branch 'origin/master' into feature/traffic_lig…
HansRobo Oct 19, 2023
c748578
feat(traffic_simulator): move confidence field from Bulb class to Tra…
HansRobo Oct 19, 2023
a773f49
feat(traffic_simulator): add EntityManager::setTrafficLightConfidence
HansRobo Oct 19, 2023
9279a08
feat(openscenario_interpreter): add PseudoTrafficSignalDetectorConfid…
HansRobo Oct 19, 2023
dd11fa3
fix(traffic_simulator): fix build errors
HansRobo Oct 19, 2023
8867357
chore: suppress warning from boost library
HansRobo Oct 19, 2023
ec0e537
refactor(simple_sensor_simulator): delete name of unused argument to …
HansRobo Oct 19, 2023
6ba444c
fix(traffic_simulator): update setTrafficLightConfidence function to …
HansRobo Oct 20, 2023
7cf026f
feat: update CustomCommandAction.PseudoTrafficSignalDetectorConfidenc…
HansRobo Oct 23, 2023
c8f3a56
refactor: renamed 'setTrafficLightConfidence' to 'setConventionalTraf…
HansRobo Oct 23, 2023
92fc727
chore: apply linter
HansRobo Oct 23, 2023
6357825
doc: update ReleaseNotes.md and OpenSCENARIOSupport.md
HansRobo Oct 24, 2023
8021f3b
Merge remote-tracking branch 'origin/master' into feature/traffic_lig…
HansRobo Oct 26, 2023
4fe0ed7
refactor: reflect the reviews
HansRobo Oct 27, 2023
9b5ee16
fix: build errors
HansRobo Nov 6, 2023
3f67f6e
Merge remote-tracking branch 'origin/master' into feature/traffic_lig…
HansRobo Nov 6, 2023
9b55d00
fix: modify comment in traffic_light.hpp
HansRobo Nov 8, 2023
098988f
Merge remote-tracking branch 'origin/master' into feature/traffic_lig…
HansRobo Nov 8, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
refactor: renamed 'setTrafficLightConfidence' to 'setConventionalTraf…
…ficLightConfidence'
  • Loading branch information
HansRobo committed Oct 23, 2023
commit c8f3a5633061a573053e301c0f9522aa1040a05d
Original file line number Diff line number Diff line change
Expand Up @@ -573,9 +573,9 @@ class SimulatorCore
}

template <typename... Ts>
static auto setTrafficLightConfidence(Ts &&... xs) -> decltype(auto)
static auto setConventionalTrafficLightConfidence(Ts &&... xs) -> decltype(auto)
{
return core->setTrafficLightConfidence(std::forward<decltype(xs)>(xs)...);
return core->setConventionalTrafficLightConfidence(std::forward<decltype(xs)>(xs)...);
}
};
};
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -103,7 +103,7 @@ struct ApplyPseudoTrafficSignalDetectorConfidenceSetAction
{
static_assert(0 < Version and Version <= 1);
if (parameters.size() == 2) {
setTrafficLightConfidence(std::stoi(parameters.at(0)), std::stod(parameters.at(1)));
setConventionalTrafficLightConfidence(std::stoi(parameters.at(0)), std::stod(parameters.at(1)));
} else {
throw Error(
"An unexpected number of arguments were passed to "
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ class API
FORWARD_TO_ENTITY_MANAGER(setDecelerationLimit);
FORWARD_TO_ENTITY_MANAGER(setDecelerationRateLimit);
FORWARD_TO_ENTITY_MANAGER(setLinearVelocity);
FORWARD_TO_ENTITY_MANAGER(setTrafficLightConfidence);
FORWARD_TO_ENTITY_MANAGER(setConventionalTrafficLightConfidence);
FORWARD_TO_ENTITY_MANAGER(setVelocityLimit);
FORWARD_TO_ENTITY_MANAGER(resetConventionalTrafficLightPublishRate);
FORWARD_TO_ENTITY_MANAGER(resetV2ITrafficLightPublishRate);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -231,7 +231,7 @@ class EntityManager
v2i_traffic_light_updater_.resetUpdateRate(rate);
}

auto setTrafficLightConfidence(lanelet::Id id, double confidence) -> void
auto setConventionalTrafficLightConfidence(lanelet::Id id, double confidence) -> void
{
for (auto & traffic_light : conventional_traffic_light_manager_ptr_->getTrafficLights(id)) {
traffic_light.get().setConfidence(confidence);
Expand Down