Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/test geometry #1147

Merged
merged 48 commits into from
Dec 15, 2023
Merged

Feature/test geometry #1147

merged 48 commits into from
Dec 15, 2023

Conversation

TauTheLepton
Copy link
Contributor

@TauTheLepton TauTheLepton commented Dec 6, 2023 •
edited
Loading

Types of PR

  • New Features
  • Upgrade of existing features
  • Bugfix

Link to the issue

Description

I have added tests to the geometry package.
Some tests do not pass, so I have removed them in the commit 5a50ead.
Almost all removed tests (with one exception) will pass after #1139 is merged. The one test that will not pass after the merge will require an additional fix that will be implemented later.
After all fixes are applied to master, the commit 5a50ead can be reverted.

How to review this PR.

Others

@TauTheLepton
Add missing BoundingBox tests
73d63e1 
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Add missing Distance tests
6653208 
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Add missing LinearAlgebra tests
14fe074 
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Correct LinearAlgebra tests
bf8e23c 
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Add missing Transform tests
61e8ce5 
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Add missing Collision tests
af25f56 
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Add missing Intersection tests
70f0ac0 
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Add missing LineSegment tests
2c207b3 
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Refactor Polygon tests
42e36f8 
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Refactor HermiteCurve tests
a884aab 
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Add missing Polygon tests
84d8aa3 
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Add missing HermiteCurve tests
9959831 
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Refactor CatmullRomSpline tests
4935fa1 
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Correct HermiteCurve tests
cfa5016 
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Add Vector3 tests
9bdbd0d 
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Refactor BoundingBox tests - add functions
a375af8 
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Refactor Distance tests - add functions
8381aa7 
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Refactor LinearAlgebra tests - add functions
98e9098 
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Refactor Transform tests - add functions
36475f0 
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Refactor Collision tests - add functions
a747750 
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Refactor Intersection tests - remove loop
eb596c2 
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Refactor Polygon tests
37f1a68 
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Correct LineSegment.initializeVectorZero test to expect error
5fd19b3 
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Add missing CatmullRomSpline tests
4e395da 
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Add missing CatmullRomSubspline tests
f4a1716 
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Correct exception type in Polygon.getMaxValueEmptyVector and Polygon.…
dbd135c 
…getMinValueEmptyVector

Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Move test helper functions into common header file
586da8c 
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Merge branch 'feature/test-geometry' into spline-subspline-tests
960ff05
@TauTheLepton
Adjust subspline tests to use test_utils.hpp
66d1cee 
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Merge remote-tracking branch 'tier4/master' into experimental/merge-m…
5f7a8e3 
…aster
@TauTheLepton
Adjust LineSegment tests to new changes
1add0ef 
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Add and correct LineSegment test cases
e437b44 
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Change test include directory: relative -> absolute
491870b 
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Revert "Change test include directory: relative -> absolute"
45f256b 
This reverts commit 491870b.

Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Clean test CMakeLists.txt
eee644f 
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Correct literals and refactor + clean code in tests
89c0ef5 
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Merge branch 'experimental/merge-master' into feature/test-geometry-s…
b454987 
…pline-subspline

Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Correct literals + refactor spline & subspline tests
689be24 
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Correct CatmullRomSpline tests
e40f907 
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Fix some incorrect tests
f20e7c0 
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Fix HermiteCurve trajectory tests
ab44b07 
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Fix linear algebra divide_zero test
294f791 
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Merge branch 'feature/test-geometry' into feature/test-geometry-splin…
6b0dc5b 
…e-subspline

Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Fix CatmullRomSpline getPolygon test
dd4f076 
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Remove empty test
ace93b9 
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Merge branch 'feature/test-geometry-spline-subspline' into feature/te…
55cf2e3 
…st-geometry

Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Remove comments
24ebe32 
Signed-off-by: Mateusz Palczuk <[email protected]>
@piotr-zyskowski-rai piotr-zyskowski-rai marked this pull request as ready for review December 14, 2023 09:09
@hakuturu583
Copy link
Collaborator

hakuturu583 commented Dec 14, 2023 •
edited
Loading

@TauTheLepton @piotr-zyskowski-rai Please pass build test before sending review request.

@piotr-zyskowski-rai piotr-zyskowski-rai marked this pull request as draft December 14, 2023 09:16
@TauTheLepton
Remove tests that do not pass
5a50ead 
These tests do not pass because they test code with bugs. When the bugs are fixed the tests will pass.

Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton
Copy link
Contributor Author

@hakuturu583
I am very sorry for the trouble.
The failing tests have been removed with the intention of restoring them in the future.
Now the build test has passed.

@TauTheLepton TauTheLepton marked this pull request as ready for review December 14, 2023 13:21
@hakuturu583 hakuturu583 merged commit 36a5fb3 into tier4:master Dec 15, 2023
7 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hakuturu583 hakuturu583 hakuturu583 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TauTheLepton @hakuturu583