-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/new release flow #1185
Merged
Merged
Feature/new release flow #1185
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
hakuturu583
added
the
bump major
If this pull request merged, bump major version of the scenario_simulator_v2
label
Feb 1, 2024
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
… into feature/new_release_flow
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
HansRobo
reviewed
Feb 14, 2024
HansRobo
reviewed
Feb 14, 2024
HansRobo
reviewed
Feb 14, 2024
HansRobo
reviewed
Feb 14, 2024
HansRobo
reviewed
Feb 14, 2024
HansRobo
reviewed
Feb 14, 2024
HansRobo
reviewed
Feb 14, 2024
HansRobo
reviewed
Feb 14, 2024
HansRobo
reviewed
Feb 14, 2024
HansRobo
reviewed
Feb 14, 2024
HansRobo
reviewed
Feb 14, 2024
Co-authored-by: Kotaro Yoshimoto <[email protected]>
Co-authored-by: Kotaro Yoshimoto <[email protected]>
Co-authored-by: Kotaro Yoshimoto <[email protected]>
Co-authored-by: Kotaro Yoshimoto <[email protected]>
Co-authored-by: Kotaro Yoshimoto <[email protected]>
Co-authored-by: Kotaro Yoshimoto <[email protected]>
Co-authored-by: Kotaro Yoshimoto <[email protected]>
Co-authored-by: Kotaro Yoshimoto <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
HansRobo
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Abstract
Background
The development team will require stricter version control in the future to ensure backward compatibility of the traffic_simulator API.
Accordingly, releases will be automated from now on, and will be done by labeling and instructing Pull Requests.
Details
After applying the new release flow, you can put one of the labels
bump major
,bump minor
, orbump patch
on the Pull Request, and when the Pull Request is merged with master, the version of scenario_simulator_v2 is bumped according to the label type.The commit history after applying the new release flow is shown in the figure below.
In the new release flow, the master tracking confirmation of branches using merge queue and the determination of the executability of release actions will be added.
Inside the merge queue, the release action is only judged as executable, and the actual release work is executed on the master branch after merge.
GitHub Actions for release are controlled in parallel to avoid data conflicts.
Destructive Changes
This Pull Request only adds the GitHub Actions, templates, etc. necessary for the release, and there are no disruptive changes with respect to the C++ API, scenario format, etc.
However, the existing release flow will be fundamentally changed and semantic versions will not be compatible.