Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support PULL_OVER as minimul risk manuever behavior in autoware_adapi_v1_msgs/system/msg/MrmState.msg #1190

Merged
merged 10 commits into from
Feb 26, 2024

Conversation

HansRobo
Copy link
Member

@HansRobo HansRobo commented Feb 15, 2024

Description

Abstract

Add support PULL_OVER as minimul risk manuever behavior in autoware_adapi_v1_msgs/system/msg/MrmState.msg.

Background

N/A

Details

This pull-request alows UserDefinedValueCondition to use PULL_OVER as a value in scenarios like below.

- name: 'a piece of condition group'
  delay: 0
  conditionEdge: none
  ByValueCondition:
    UserDefinedValueCondition:
      value: PULL_OVER
      name: ego.currentMinimumRiskManeuverState.behavior
      rule: equalTo

This pull-request has backward-compatibility.
(No errors are occured with PULL_OVER-less version of autoware_adapi_v1_msgs.)

References

autoware_adapi_v1_msgs/system/msg /MrmState.msg

regression test result (INTERNAL LINK)

Destructive Changes

N/A (See Details section for backward-compatibility)

Known Limitations

N/A

Copy link

github-actions bot commented Feb 15, 2024

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@HansRobo HansRobo added the bump minor If this pull request merged, bump minor version of the scenario_simulator_v2 label Feb 15, 2024
@HansRobo HansRobo requested a review from yamacir-kit February 22, 2024 06:54
@HansRobo HansRobo marked this pull request as ready for review February 22, 2024 06:55
@yamacir-kit yamacir-kit changed the title Support PULL_OVER as minimul risk manuever behavior in autoware_adapi_v1_msgs/system/msg /MrmState.msg Support PULL_OVER as minimul risk manuever behavior in autoware_adapi_v1_msgs/system/msg/MrmState.msg Feb 26, 2024
@yamacir-kit yamacir-kit merged commit c4470c8 into master Feb 26, 2024
14 checks passed
@yamacir-kit yamacir-kit deleted the feature/mrm_behavior/pull_over branch February 26, 2024 08:03
@github-actions github-actions bot restored the feature/mrm_behavior/pull_over branch February 26, 2024 08:04
@github-actions github-actions bot deleted the feature/mrm_behavior/pull_over branch February 26, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump minor If this pull request merged, bump minor version of the scenario_simulator_v2 wait for regression test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants