Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix workflow trigger for CheckLabel.yaml #1191

Merged
merged 1 commit into from
Feb 15, 2024
Merged

Conversation

HansRobo
Copy link
Member

Description

Abstract

To realize a trigger that fires when label is added or removed from pull-request, you should use pull_request trigger with labeled and unlabeled types instead of label trigger.

Background

N/A

Details

N/A

References

Destructive Changes

N/A

Known Limitations

N/A

@HansRobo HansRobo added the bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 label Feb 15, 2024
Copy link

github-actions bot commented Feb 15, 2024

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line. This pull request only changes the trigger of the GitHub Actions.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line. This pull request only changes the trigger of the GitHub Actions. No need for documentation, especially since no code differences exist

@HansRobo
Copy link
Member Author

Test for labeled and unlabeled

@HansRobo HansRobo removed the bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 label Feb 15, 2024
@HansRobo
Copy link
Member Author

The unlabeled type of pull_request trigger works well.
image

@HansRobo HansRobo added the bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 label Feb 15, 2024
@HansRobo
Copy link
Member Author

The labeled type of pull_request trigger works well.
image

@HansRobo HansRobo requested a review from hakuturu583 February 15, 2024 07:47
@HansRobo HansRobo marked this pull request as ready for review February 15, 2024 07:47
@hakuturu583 hakuturu583 self-assigned this Feb 15, 2024
@hakuturu583 hakuturu583 merged commit bc87306 into master Feb 15, 2024
15 of 16 checks passed
@hakuturu583 hakuturu583 deleted the HansRobo-patch-1 branch February 15, 2024 07:56
@github-actions github-actions bot restored the HansRobo-patch-1 branch February 15, 2024 07:57
@github-actions github-actions bot deleted the HansRobo-patch-1 branch February 15, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants