Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/default matching distance #1194

Merged
merged 17 commits into from
Feb 22, 2024
Merged

Conversation

hakuturu583
Copy link
Collaborator

@hakuturu583 hakuturu583 commented Feb 19, 2024

Description

Abstract

  • Unify the calculation criteria of threshold values used for lane coordinate system pose calculation to some extent for each Entity.
  • Changed MiscObject/Pedestrian Entity to take crosswalks into account.

Background

In #1189 and #1192, it was indicated that the existing lane coordinate system calculations were extremely complex, with different thresholds in various places, etc., and that it was presumed that proper processing was not being done.

Details

  • Unify the calculation criteria of threshold values used for lane coordinate system pose calculation to some extent for each Entity.
    • The matching distance values for the pose calculation in the lane coordinate system varied depending on various conditions. These were simplified and changed to basically use the matching distance determined for each Entity.
    • If the entity is the Ego or Vehicle entity, let $L_m$ be the length of the horizontal bar used in the lane coordinate system calculation and the tread of the front wheels be $t_f$ and the tread of the rear wheels be $t_r$. $$L_m = max(t_r, t_f) + 2.0$$
    • If the entity is the Pedestrian or MiscObject entity, let $L_m$ be the length of the horizontal bar used in the lane coordinate system calculation and width of the bounding box be $L_w$ $$L_m = L_w + 2.0$$

lane_pose_calculation

  • Changed MiscObject/Pedestrian Entity to take crosswalks into account
    • They were set not to be taken into account for all Entities at spawn.

References

Related issues / Pull requests

#1189
This pull request is depends on #1192. This pull request become ready for review after merging #1192.

Regression test result

https://github.com/tier4/sim_evaluation_tools/issues/244

Destructive Changes

Although this Pull Request does not significantly change the processing flow of the existing algorithm, 100% backward compatibility does not exist because some of the thresholds have been changed.
However, it is assumed that the impact will be limited to a level that does not affect the existing scenario.
In fact, it has been confirmed that regression does not occur in existing scenarios.
See test log for details.

Known Limitations

This Pull Request only changes the thresholds of the existing algorithm, and no major processing method changes exist.
Therefore, the specification that the lane coordinate system calculation fails if the horizontal bar extending from the Entity does not touch the curve at the center of the lane remains.

Copy link

github-actions bot commented Feb 19, 2024

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@hakuturu583 hakuturu583 added bump minor If this pull request merged, bump minor version of the scenario_simulator_v2 wait for regression test labels Feb 19, 2024
@hakuturu583 hakuturu583 requested a review from HansRobo February 21, 2024 13:19
@hakuturu583 hakuturu583 marked this pull request as ready for review February 21, 2024 13:19
@hakuturu583 hakuturu583 self-assigned this Feb 22, 2024
hakuturu583 and others added 5 commits February 22, 2024 15:02
@HansRobo HansRobo merged commit 9f621fe into master Feb 22, 2024
10 checks passed
@HansRobo HansRobo deleted the feature/default_matching_distance branch February 22, 2024 07:57
@github-actions github-actions bot restored the feature/default_matching_distance branch February 22, 2024 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump minor If this pull request merged, bump minor version of the scenario_simulator_v2 wait for regression test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants