-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/default matching distance #1194
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masaya Kataoka <[email protected]>
…scenario_simulator_v2 into feature/default_matching_distance
… entity Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
hakuturu583
added
bump minor
If this pull request merged, bump minor version of the scenario_simulator_v2
wait for regression test
labels
Feb 19, 2024
Signed-off-by: Masaya Kataoka <[email protected]>
…ault_matching_distance
…m/tier4/scenario_simulator_v2 into feature/default_matching_distance
HansRobo
reviewed
Feb 22, 2024
simulation/behavior_tree_plugin/src/pedestrian/pedestrian_action_node.cpp
Outdated
Show resolved
Hide resolved
HansRobo
reviewed
Feb 22, 2024
HansRobo
reviewed
Feb 22, 2024
simulation/traffic_simulator/include/traffic_simulator/entity/entity_manager.hpp
Outdated
Show resolved
Hide resolved
…entity_manager.hpp Co-authored-by: Kotaro Yoshimoto <[email protected]>
…ault_matching_distance Signed-off-by: Masaya Kataoka <[email protected]>
…m/tier4/scenario_simulator_v2 into feature/default_matching_distance
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
HansRobo
approved these changes
Feb 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bump minor
If this pull request merged, bump minor version of the scenario_simulator_v2
wait for regression test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Abstract
Background
In #1189 and #1192, it was indicated that the existing lane coordinate system calculations were extremely complex, with different thresholds in various places, etc., and that it was presumed that proper processing was not being done.
Details
References
Related issues / Pull requests
#1189
This pull request is depends on #1192. This pull request become ready for review after merging #1192.
Regression test result
https://github.com/tier4/sim_evaluation_tools/issues/244
Destructive Changes
Although this Pull Request does not significantly change the processing flow of the existing algorithm, 100% backward compatibility does not exist because some of the thresholds have been changed.
However, it is assumed that the impact will be limited to a level that does not affect the existing scenario.
In fact, it has been confirmed that regression does not occur in existing scenarios.
See test log for details.
Known Limitations
This Pull Request only changes the thresholds of the existing algorithm, and no major processing method changes exist.
Therefore, the specification that the lane coordinate system calculation fails if the horizontal bar extending from the Entity does not touch the curve at the center of the lane remains.