-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/split rviz packages #1195
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
… into feature/split_rviz_packages
hakuturu583
added
the
bump patch
If this pull request merged, bump patch version of the scenario_simulator_v2
label
Feb 21, 2024
… into feature/split_rviz_packages
… into feature/split_rviz_packages
…4/scenario_simulator_v2 into feature/split_rviz_packages
… into feature/split_rviz_packages
…4/scenario_simulator_v2 into feature/split_rviz_packages
yamacir-kit
approved these changes
Feb 26, 2024
… into feature/split_rviz_packages
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Abstract
A non-intuitive package arrangement was identified and corrected.
Background
Details
openscneario_visualization::OpenScenarioVisualizationComponent
intotraffic_simulator::VisualizationComponent
and move it totraffic_simulator
package.References
Since we only moved the code for the visualization part, no regression test was performed except for the GitHub Actions.
Since the path of the rviz file has been changed, the launch file, which reads the rviz file, was tested locally to confirm that it works properly.
Destructive Changes
This pull request just changing directory of source code.
So no destructive changes.
Known Limitations
N/A