Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/split rviz packages #1195

Merged
merged 11 commits into from
Feb 26, 2024
Merged

Feature/split rviz packages #1195

merged 11 commits into from
Feb 26, 2024

Conversation

hakuturu583
Copy link
Collaborator

@hakuturu583 hakuturu583 commented Feb 19, 2024

Description

Abstract

A non-intuitive package arrangement was identified and corrected.

Background

Details

  • The openscenario_visualization_components is not related to OpenSCENARIO, it is just visualize traffic simulation result.
    • Rename openscneario_visualization::OpenScenarioVisualizationComponent into traffic_simulator::VisualizationComponent and move it to traffic_simulator package.
  • Some of the rviz plugins does not in rviz_plugins directory.
    • Move openscenario_visualization packages to rviz_plugins direcotyr.

References

Since we only moved the code for the visualization part, no regression test was performed except for the GitHub Actions.
Since the path of the rviz file has been changed, the launch file, which reads the rviz file, was tested locally to confirm that it works properly.

Screenshot from 2024-02-22 13-23-28

Destructive Changes

This pull request just changing directory of source code.
So no destructive changes.

Known Limitations

N/A

Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
@hakuturu583 hakuturu583 self-assigned this Feb 19, 2024
Copy link

github-actions bot commented Feb 19, 2024

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@hakuturu583 hakuturu583 added the bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 label Feb 21, 2024
@hakuturu583 hakuturu583 marked this pull request as ready for review February 22, 2024 04:39
@yamacir-kit yamacir-kit merged commit 8503d5a into master Feb 26, 2024
10 checks passed
@yamacir-kit yamacir-kit deleted the feature/split_rviz_packages branch February 26, 2024 09:25
@github-actions github-actions bot restored the feature/split_rviz_packages branch February 26, 2024 09:26
@github-actions github-actions bot deleted the feature/split_rviz_packages branch February 26, 2024 09:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants