-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/reset behavior plugin #1210
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
hakuturu583
added
the
bump minor
If this pull request merged, bump minor version of the scenario_simulator_v2
label
Mar 7, 2024
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
… into feature/reset_behavior_plugin Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
… into feature/reset_behavior_plugin
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
yamacir-kit
requested changes
Mar 25, 2024
simulation/traffic_simulator/include/traffic_simulator/entity/entity_manager.hpp
Outdated
Show resolved
Hide resolved
simulation/traffic_simulator/include/traffic_simulator/entity/entity_manager.hpp
Outdated
Show resolved
Hide resolved
simulation/traffic_simulator/include/traffic_simulator/entity/entity_manager.hpp
Outdated
Show resolved
Hide resolved
…entity_manager.hpp Co-authored-by: Tatsuya Yamasaki <[email protected]>
Co-authored-by: Tatsuya Yamasaki <[email protected]>
Co-authored-by: Tatsuya Yamasaki <[email protected]>
Signed-off-by: Masaya Kataoka <[email protected]>
yamacir-kit
approved these changes
Mar 27, 2024
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
bump minor
If this pull request merged, bump minor version of the scenario_simulator_v2
wait for regression test
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Abstract
Enable reset behavior plugin of entity.
Background
Previously, no means was provided to reset the behavior plugin, and the state had to be saved and respawned.
This pull request provides functionality to allow plugins to be replaced more easily.
Details
Enable reset behavior plugin of entity.
You can use this feature by function below.
First argument is the name of the entity you want to reset behavior plugin.
Second argument is the name of the behavior plugin you want to set.
Internally, the following operations are performed
References
Regression test result
Destructive Changes
N/A
Known Limitations
API::resetBehaviorPlugin
function cannot be called on non-spawned EntityAPI::resetBehaviorPlugin
function cannot be called for entities other than vehicle/pedestrian because behavior plugin does not exist for entities other than vehicle/pedestrian.