Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: include all topic to rosbag #1211

Merged
merged 1 commit into from
Mar 13, 2024
Merged

chore: include all topic to rosbag #1211

merged 1 commit into from
Mar 13, 2024

Conversation

HansRobo
Copy link
Member

@HansRobo HansRobo commented Mar 8, 2024

Description

Abstract

scenario_simulator_v2 starts to recording the /planning/scenario_planning/lane_driving/behavior_planning/behavior_velocity_planner/debug/intersection topic again.

Background

In #829, the /planning/scenario_planning/lane_driving/behavior_planning/behavior_velocity_planner/debug/intersection topic has excluded from recording target due to its so large size.
But after autowarefoundation/autoware.universe#1483, Internal research has confirmed that the size has improved significantly.

Details

N/A

References

#829
autowarefoundation/autoware.universe#1483

Destructive Changes

N/A

Known Limitations

N/A

Copy link

github-actions bot commented Mar 8, 2024

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@HansRobo HansRobo added the bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 label Mar 8, 2024
@HansRobo HansRobo self-assigned this Mar 13, 2024
@HansRobo HansRobo requested a review from yamacir-kit March 13, 2024 09:37
@HansRobo HansRobo marked this pull request as ready for review March 13, 2024 09:37
@yamacir-kit yamacir-kit merged commit 5a3ddcd into master Mar 13, 2024
15 checks passed
@yamacir-kit yamacir-kit deleted the chore/record_all branch March 13, 2024 09:48
@github-actions github-actions bot restored the chore/record_all branch March 13, 2024 09:49
@github-actions github-actions bot deleted the chore/record_all branch March 13, 2024 09:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants