Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Delete edited trigger from release workflow #1214

Merged
merged 1 commit into from
Mar 21, 2024
Merged

Conversation

HansRobo
Copy link
Member

@HansRobo HansRobo commented Mar 21, 2024

Description

Abstract

When merged pull-request is edited, the release workflow executed wrongly.
It can be avoided in operation, but the possibility of human error remains, so I remove the trigger in this pull-request.

Background

N/A

Details

N/A

References

The releases that published wrongly

Destructive Changes

N/A

Known Limitations

N/A

@HansRobo HansRobo added the bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 label Mar 21, 2024
@HansRobo HansRobo requested a review from hakuturu583 March 21, 2024 01:54
Copy link

github-actions bot commented Mar 21, 2024

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@hakuturu583 hakuturu583 merged commit b0505cb into master Mar 21, 2024
12 checks passed
@hakuturu583 hakuturu583 deleted the fix/release_trigger branch March 21, 2024 02:22
@github-actions github-actions bot restored the fix/release_trigger branch March 21, 2024 02:23
@HansRobo HansRobo deleted the fix/release_trigger branch March 21, 2024 02:23
@HansRobo HansRobo restored the fix/release_trigger branch March 21, 2024 02:23
@HansRobo HansRobo deleted the fix/release_trigger branch May 17, 2024 08:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants