Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

refactor openscenario validator package #1254

Merged
merged 5 commits into from
May 30, 2024

Conversation

HansRobo
Copy link
Member

@HansRobo HansRobo commented May 20, 2024

Description

Abstract

Modified openscenario_validator so that it can be used as a header-only library.

Background

N/A

Details

N/A

References

regression test: https://github.com/tier4/sim_evaluation_tools/issues/282

Destructive Changes

OpenSCENARIOValidator class users will be affected by this change.
(But, the class is not included in the interfaces that should be maintained, the version increment is at the patch level.)

Known Limitations

N/A

Copy link

github-actions bot commented May 20, 2024

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@HansRobo HansRobo added wait for regression test bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 labels May 20, 2024
@HansRobo HansRobo marked this pull request as ready for review May 22, 2024 05:35
@HansRobo HansRobo requested a review from yamacir-kit May 22, 2024 05:35
@HansRobo HansRobo merged commit 37fecc2 into master May 30, 2024
13 checks passed
@github-actions github-actions bot deleted the refactor/openscenario_validator branch May 30, 2024 05:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants