-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(parameters_visualization): visualize test iteration parameters #1346
feat(parameters_visualization): visualize test iteration parameters #1346
Conversation
…rameters visualization Signed-off-by: Ahmed Ebrahim <[email protected]>
…include the new plugin Signed-off-by: Ahmed Ebrahim <[email protected]>
…toring, and some fixes
@ahmeddesokyebrahim Why the base branch of this pull request is not master branch? |
Thanks @hakuturu583 -san for your reply. So, the needed fix now is to have the target or base branch for the PR to be master. Is it correct ? |
Hi @hakuturu583 -san, Is this PR set up as needed ? If yes, I can close this one and consider the new PR. |
Yes. I think this base branch of this pull request should be master. |
I think this is very helpful feature. |
Thanks for your comment @hakuturu583 -san |
@ahmeddesokyebrahim Thanks! |
@ahmeddesokyebrahim Thak you for re-opening new pull request. |
Thanks for your comment @hakuturu583 -san. I close this PR with this comment and we consider the other PR based on master branch. Thanks again. |
Description
fixes #1272
Abstract
This PR is to add the ability for scenario simulator to report the parameters used in each iteration as described in this feature request.
The PR is adding this parameters reporting using both command line print and rviz plugin visualization that can enabled when needed
Background
Please refer to the feature request.
Details
Using this PR, the parameters are printed to command line and visualized in RVIZ as follows :
References
N.A
Destructive Changes
N.A
Known Limitations