Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/request enable autoware control #1465

Merged
merged 6 commits into from
Dec 13, 2024

Conversation

satoshi-ota
Copy link
Contributor

Description

Please check examples and comment out this sentence. Minimal example is here and detailed example is here

Abstract

I fixed API to make request to enable autoware control when the ego respawns.

Background

Now the autoware control will be disable when the ego respawns. I guess that it not expected behavior.

Details

I confirmed the autoware control was automatically enabled when the ego respawns by using API::respawn.

References

N/A

Destructive Changes

N/A

Known Limitations

N/A

Copy link

github-actions bot commented Dec 2, 2024

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@HansRobo HansRobo added wait for regression test bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 labels Dec 5, 2024
@HansRobo HansRobo self-requested a review December 11, 2024 10:00
Copy link
Member

@HansRobo HansRobo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with no regression

@HansRobo HansRobo merged commit 02b0302 into master Dec 13, 2024
16 checks passed
@github-actions github-actions bot deleted the fix/request-enable-autoware-control branch December 13, 2024 01:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants