-
Notifications
You must be signed in to change notification settings - Fork 60
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
make Entity lane-changeable everywhere #1468
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Checklist for reviewers ☑️All references to "You" in the following text refer to the code reviewer.
|
…s/getRightLaneletIds
HansRobo
added
wait for regression test
bump patch
If this pull request merged, bump patch version of the scenario_simulator_v2
labels
Dec 9, 2024
hakuturu583
added
bump minor
If this pull request merged, bump minor version of the scenario_simulator_v2
and removed
bump patch
If this pull request merged, bump patch version of the scenario_simulator_v2
labels
Dec 10, 2024
hakuturu583
requested changes
Dec 10, 2024
simulation/traffic_simulator/include/traffic_simulator/hdmap_utils/hdmap_utils.hpp
Outdated
Show resolved
Hide resolved
…HdMapUtils::getLeftLaneletIds/getRightLaneletIds
hakuturu583
approved these changes
Dec 10, 2024
Quality Gate passedIssues Measures |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Abstract
allow lane-changes everywhere in
VEHICLE_WITH_ROAD_SHOULDER
rouitng graphBackground
Basically, the lanelet2 lane change permission/disallowance setting is intended for Autoware and was not designed with the behavior of entities running in the traffic_simulator in mind.
Also, when an entity is commanded to change lanes in a scenario, it is considered appropriate to change lanes, even if that command ignores the Road Traffic Act and lane change settings.
Details
road
androad_shoulder
intosolid
(un-lane-changeable) fromdashed
(lane-changeable)VEHICLE_WITH_ROAD_SHOULDER
rouitng graphdetails of
getLeftLaneletIds
/getRightLaneletIds
changesIn this pull-request, I changed
lanelet2
function mapping switched byinclude_oppsite_direction
flag.previous mappping
include_oppsite_direction
: true(The de facto default)lanelet::routing::RoutingGraph::adjacentRights/adjacentLefts
include_oppsite_direction
: falselanelet::routing::RoutingGraph::rights/lefts
incoming mappping
include_oppsite_direction
: trueinclude_oppsite_direction
: false(The de facto default)lanelet::routing::RoutingGraph::rights/lefts
Important
lanelet::routing::RoutingGraph::adjacentRights/adjacentLefts
do not have the ability to acquire adjacent lanes,including the opposite lane.
The only difference between
rights
andadjacentRights
is whether the adjacent lanelet they acquire is routable or not.(Both do not have the ability to acquire the opposite lanes.)
routing changes possibility due to this change
In this pull-request allows lane-changes everywhere.
This change will result in some changes to routing, as exemplified by the tests below.
Routing will always prioritize smaller cost (in this case, shorter distance), so longitudinal distance measurements may be smaller than before.
Before this pull-request
The routing graph and adjacent lane search options only allow you to get this route.
After this pull-request
By expanding the range of the RoutingGraph, we can compare more candidates and select a route with a shorter distance (in this case, the route is shorter if it goes on the inside of the curve).
References
Regression Test: OK
Destructive Changes
Please see "routing changes possibility due to this change" in
Details
section.Known Limitations