Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Sonor Cloud Issue8-3 #1474

Merged
merged 3 commits into from
Dec 10, 2024
Merged

Fix Sonor Cloud Issue8-3 #1474

merged 3 commits into from
Dec 10, 2024

Conversation

TakanoTaiga
Copy link
Member

@TakanoTaiga TakanoTaiga self-assigned this Dec 4, 2024
Copy link

github-actions bot commented Dec 4, 2024

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@TakanoTaiga TakanoTaiga changed the title Fix Sonor Cloud Issue: should be declared "const". Fix Sonor Cloud Issue8-3 Dec 4, 2024
@TakanoTaiga TakanoTaiga marked this pull request as ready for review December 4, 2024 14:08
@TakanoTaiga TakanoTaiga added refactor bump minor If this pull request merged, bump minor version of the scenario_simulator_v2 bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 and removed bump minor If this pull request merged, bump minor version of the scenario_simulator_v2 labels Dec 5, 2024
Copy link
Collaborator

@hakuturu583 hakuturu583 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, start regression test.

Copy link
Collaborator

@hakuturu583 hakuturu583 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hakuturu583 hakuturu583 merged commit 81c8088 into master Dec 10, 2024
14 checks passed
@github-actions github-actions bot deleted the fix/sonor-cloud-issue-8-3 branch December 10, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 refactor wait for regression test
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants