Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix/speed condition/backward compatibility #1486

Merged
merged 4 commits into from
Dec 13, 2024

Conversation

yamacir-kit
Copy link
Collaborator

@yamacir-kit yamacir-kit commented Dec 12, 2024

Description

Abstract

SpeedCondition was updated to comply with OpenSCENARIO XML 1.3.1 in #1469, but this caused a loss of compatibility with previous behavior. This pull request solves this by adding a compatibility mode parameter that allows SpeedCondition to maintain the previous behavior.

Background

None.

Details

Scenario UC-v3-E-04-00101_002_case01_cmn_general fails in master branch, but succeeds in this pull request's branch. And when moving backwards, a negative value is returned from SpeedCondition as before.

References

None.

Destructive Changes

None.

Known Limitations

None.

@yamacir-kit yamacir-kit self-assigned this Dec 12, 2024
Copy link

github-actions bot commented Dec 12, 2024

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

@yamacir-kit yamacir-kit added bug Something isn't working bump patch If this pull request merged, bump patch version of the scenario_simulator_v2 wait for regression test labels Dec 12, 2024
@yamacir-kit yamacir-kit requested a review from HansRobo December 13, 2024 02:00
@yamacir-kit yamacir-kit marked this pull request as ready for review December 13, 2024 02:04
@yamacir-kit yamacir-kit merged commit 2aa6486 into master Dec 13, 2024
16 checks passed
@github-actions github-actions bot deleted the fix/speed-condition/backward-compatibility branch December 13, 2024 03:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working bump patch If this pull request merged, bump patch version of the scenario_simulator_v2
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants