Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rjd 1388/follow trajectory fix #1494

Merged
merged 19 commits into from
Dec 20, 2024

Conversation

TauTheLepton
Copy link
Contributor

@TauTheLepton TauTheLepton commented Dec 18, 2024

Merge this before #1449

Description

This PR fixes a bug in follow trajectory action. The bug was caused by wrong data field initialization order. This wrong order caused one function to use a data field before its initialization, and wrong speed and acceleration values were calculated.

This was the source of a bug. In initialization it was hidden which functions used which members and wrong initialization order was used

Signed-off-by: Mateusz Palczuk <[email protected]>
Signed-off-by: Mateusz Palczuk <[email protected]>
Signed-off-by: Mateusz Palczuk <[email protected]>
Signed-off-by: Mateusz Palczuk <[email protected]>
@TauTheLepton TauTheLepton self-assigned this Dec 18, 2024
@TauTheLepton TauTheLepton requested a review from robomic December 19, 2024 09:48
Copy link

@TauTheLepton TauTheLepton marked this pull request as ready for review December 19, 2024 14:02
@robomic robomic merged commit d88cdd1 into RJD-1388/follow_trajectory Dec 20, 2024
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants