Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: mock test launch option #1496

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
Open

Conversation

satoshi-ota
Copy link
Contributor

@satoshi-ota satoshi-ota commented Dec 22, 2024

Description

  • enable respawn_ego mock test.
  • fix launch option.

Abstract

Missing necessary parameter simulate_localization for mock_test.launch.py. As a result, mock test executed without localization simulation.

Background

When I tryied adding and improving respawn_ego test, I met wierd behavior (please see following movie). I found scenario_simulator_v2 didn't simulate localization even the autoware didn't launch any localization module.

Related PR: #1484

movie-2024-12-23_08.39.48.mp4

Details

This PR has two contents.

  1. Enabled respawn_ego mock test so that we can find regression of respawn functionality. Additionally, I improved test scenario. The ego spawns at lane id 34621 and moves to 34606 during first 10 sec. After that, the ego will respawns at lane id 34576 and moves to 34564. If the ego can reach goal lane by within 60 sec, the scenario will be success. (please see following movie.)
  2. Added launch option to simulate localization to mock_test.launch.py.
movie-2024-12-23_08.16.06.mp4

References

N/A

Destructive Changes

N/A

Known Limitations

N/A

Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: satoshi-ota <[email protected]>
Signed-off-by: satoshi-ota <[email protected]>
Copy link

Checklist for reviewers ☑️

All references to "You" in the following text refer to the code reviewer.

  • Is this pull request written in a way that is easy to read from a third-party perspective?
  • Is there sufficient information (background, purpose, specification, algorithm description, list of disruptive changes, and migration guide) in the description of this pull request?
  • If this pull request contains a destructive change, does this pull request contain the migration guide?
  • Labels of this pull request are valid?
  • All unit tests/integration tests are included in this pull request? If you think adding test cases is unnecessary, please describe why and cross out this line.
  • The documentation for this pull request is enough? If you think adding documents for this pull request is unnecessary, please describe why and cross out this line.

Signed-off-by: satoshi-ota <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant