Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Abstract
Add
const std::function<void(const std::string &)> & despawn_function
argument to the TrafficSink/TrafficController class.Background
Fixed #1464 to call
EntityManager::despawnEntity
function instead ofAPI::despawn
function during PR review process.The
API::despawn
function included a function to communicate with sensor_simulator, and the function to delete Entity in sensor simulator via inter-process communication was implemented.The
EntityManager::despawnEntity
function has been changed to call theEntityManager::despawnEntity
function, so Entity in sensor simulator is no longer deleted.Details
Add
const std::function<void(const std::string &)> & despawn_function
argument to the TrafficSink/TrafficController class and passAPI::despawn
function in member initialize list of the API class.References
#1464
https://star4.slack.com/archives/C04TZBEABDM/p1735261646158039?thread_ts=1735102371.414719&cid=C04TZBEABDM
Destructive Changes
N/A
Known Limitations
The design of this PR is not desirable, but for now it is a PR to solve the problems that have occurred.
In the future, use the Job class to replace the TrafficSink/TrafficSource class for a more reasonable refactor.