Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add PandarOT-128 #42

Merged
merged 2 commits into from
Mar 5, 2024
Merged

feat: add PandarOT-128 #42

merged 2 commits into from
Mar 5, 2024

Conversation

yukkysaito
Copy link
Collaborator

@yukkysaito yukkysaito commented Mar 5, 2024 •
edited
Loading

Add Pandar OT-128
image
image

@yukkysaito
add PandarOT-128
e2d25a3 
Signed-off-by: Yukihiro Saito <[email protected]>
@yukkysaito yukkysaito requested a review from KYabuuchi March 5, 2024 08:05
@yukkysaito yukkysaito marked this pull request as ready for review March 5, 2024 10:32
@yukkysaito yukkysaito requested a review from tkimura4 March 5, 2024 10:33
tkimura4
tkimura4 approved these changes Mar 5, 2024
View reviewed changes
Copy link

@tkimura4 tkimura4 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@yukkysaito yukkysaito requested review from shmpwk and tkimura4 March 5, 2024 10:41
@yukkysaito yukkysaito merged commit 3218254 into main Mar 5, 2024
9 of 10 checks passed
@yukkysaito yukkysaito deleted the feature/add_hesai_ot128_urdf branch March 5, 2024 10:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@KYabuuchi KYabuuchi Awaiting requested review from KYabuuchi

@shmpwk shmpwk Awaiting requested review from shmpwk

@tkimura4 tkimura4 Awaiting requested review from tkimura4

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@yukkysaito @tkimura4