-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(logpacker): add rosbag recoding api #114
Conversation
Signed-off-by: ito-san <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Memo:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The namespace should be shared and it should be |
Filed a new PR, please see tier4/autoware-documentation#44. |
Signed-off-by: ito-san <[email protected]>
Signed-off-by: ito-san <[email protected]>
Related Links
TIER IV INTERNAL SLACK
Description
The request command should use ROS2 service instead of topic, and the status should be exchanged in numerical format rather than in string.
Changes
/bagpacker/record std_msgs/Bool
has been discontinued./api/autoware/set/rosbag_record tier4_external_api_msgs::srv::SetRosbagRecord
/bagpacker/state std_msgs/msg/String
has been discontinued./api/autoware/get/rosbag_record_status tier4_external_api_msgs::msg::RosbagRecordStatus
ros2 bag record
command is currently running or not./bagpacker/condition std_msgs/Bool
has been discontinued since this duplicates the above.Remarks
Pre-Review Checklist for the PR Author
PR Author should check the checkboxes below when creating the PR.
Checklist for the PR Reviewer
Reviewers should check the checkboxes below before approval.
Post-Review Checklist for the PR Author
PR Author should check the checkboxes below before merging.
CI Checks