Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(tier4_localization_msgs): add InitilizeLocalization srv #121

Merged
merged 5 commits into from
May 27, 2024
Merged

feat(tier4_localization_msgs): add InitilizeLocalization srv #121

merged 5 commits into from
May 27, 2024

Conversation

YamatoAndo
Copy link
Contributor

@YamatoAndo YamatoAndo commented May 17, 2024 •
edited
Loading

Related Links

Description

add InitilizeLocalization srv for autowarefoundation/autoware.universe#7048

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Code is properly formatted
  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code is properly formatted
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

YamatoAndo added 2 commits May 17, 2024 14:44
@YamatoAndo
add InitializeLocalization.srv
f172a4f 
Signed-off-by: Yamato Ando <[email protected]>
@YamatoAndo
add new line
281b633 
Signed-off-by: Yamato Ando <[email protected]>
@YamatoAndo YamatoAndo mentioned this pull request May 17, 2024
Merged
7 tasks
@YamatoAndo YamatoAndo marked this pull request as ready for review May 17, 2024 08:17
isamu-takagi
isamu-takagi approved these changes May 17, 2024
View reviewed changes
Copy link
Contributor

@isamu-takagi isamu-takagi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YamatoAndo
add description
49ccda1 
Signed-off-by: Yamato Ando <[email protected]>
@YamatoAndo
remove unnecessary space
f9f8067 
Signed-off-by: Yamato Ando <[email protected]>
@YamatoAndo YamatoAndo force-pushed the feat/tier4_localization_msgs/add_initilizelocalization_srv branch from bc4f564 to f9f8067 Compare May 17, 2024 10:40
yukkysaito
yukkysaito approved these changes May 17, 2024
View reviewed changes
Copy link
Collaborator

@yukkysaito yukkysaito left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@YamatoAndo
Copy link
Contributor Author

YamatoAndo commented May 20, 2024 •
edited
Loading

@mitsudome-r I don't have write access to this repository. If this pr is OK with you, please merge this pr.

@YamatoAndo
Copy link
Contributor Author

@mitsudome-r

@YamatoAndo
Copy link
Contributor Author

@mitsudome-r hello?

@YamatoAndo
Copy link
Contributor Author

@mitsudome-r @mitsudome-r @mitsudome-r

@mitsudome-r mitsudome-r merged commit 3c13a40 into tier4:tier4/universe May 27, 2024
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mitsudome-r mitsudome-r mitsudome-r approved these changes

@isamu-takagi isamu-takagi isamu-takagi approved these changes

@yukkysaito yukkysaito yukkysaito approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@YamatoAndo @yukkysaito @mitsudome-r @isamu-takagi