Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(tier4_control_msgs): add pause source field for pause interface improvement #82

Closed
wants to merge 1 commit into from

Conversation

brkay54
Copy link
Contributor

@brkay54 brkay54 commented Apr 16, 2023

Related Links

To can be made vehicle paused from other nodes, I improved pause_interface. This message and service files also should be changed.

autowarefoundation/autoware.universe#2528 (comment)

Description

Remarks

Pre-Review Checklist for the PR Author

PR Author should check the checkboxes below when creating the PR.

  • Code is properly formatted
  • Assign PR to reviewer

Checklist for the PR Reviewer

Reviewers should check the checkboxes below before approval.

  • Commits are properly organized and messages are according to the guideline
  • Code is properly formatted
  • PR title describes the changes

Post-Review Checklist for the PR Author

PR Author should check the checkboxes below before merging.

  • All open points are addressed and tracked via issues or tickets
  • Write release notes

CI Checks

  • Build and test for PR: Required to pass before the merge.
  • Check spelling: NOT required to pass before the merge. It is up to the reviewer(s). See here if you want to add some words to the spell check dictionary.

@brkay54
Copy link
Contributor Author

brkay54 commented Apr 26, 2023

I can not assign reviewer @kenji-miyake , could you assign someone? 🙏🏼

@kenji-miyake
Copy link
Contributor

@yukkysaito @TakaHoribe cc @mitsudome-r I think you guys are the appropriate reviewers. Could you please review this?

@yukkysaito
Copy link
Collaborator

@mitsudome-r Can you explain this PR at the meeting?

@mitsudome-r
Copy link
Collaborator

mitsudome-r commented Apr 27, 2023

@brkay54
We had some improvements in emergency handler to achieve moderate braking for predicted path.
Maybe we can have another discussion in the next WG call with @TakaHoribe and @yukkysaito if we can use that system instead of adding new interface.

@brkay54
Copy link
Contributor Author

brkay54 commented May 2, 2023

Hi, @mitsudome-r -san, Are we gonna talk about it today's Software WG?

@mitsudome-r
Copy link
Collaborator

@brkay54 Let's talk in the Planning/Control meeting this week.
Just as a heads up, I have talked with @isamu-takagi, @yukkysaito, and @TakaHoribe, but we might have to change the approach.

Takagi-san said that he doesn't want to have pause interface used to "decelerate" the vehicle. It is more for make the vehicle stay at stop state. (e.g., like side brake or park gear)
Instead we would like to add another filter in vehicle command gate for moderate stop next to emergency stop as the following:

  • Modify vehicle_cmd_gate
    • add ~/moderate_stop service
    • add parameter moderate_stop_deceleration
    • This is similar to emergency stop, but stop with lower deceleration
    • When ever vehicle_cmd_gate receives stop request from moderate_stop topic, then it will overwrite control message using given parameter:
      • velocity = 0
      • acceleration = $moderate_stop_deceleration
  • moderate_stop service type:
    • Time stamp
    • bool stop
    • string request_source

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants