feat(deepen_to_t4): add paint label downloader #107

nanoshimarobot · 2024-05-24T03:33:31Z

Description

Add a feature to download 3D semantic painting labels and write them to pcd files located in non_annotated_t4_format.
This feature enables the local storage of annotation information for 3D point clouds.
I used this api for downloading label data.

How to test

test data

Any 3D painted deepen dataset
non_annotated_t4_format

test command

Edit convert_deepen_to_t4_paint_sample.yaml
Modify input_base and dataset corresponding as necessary.

Run

  python3 -m perception_dataset.deepen.download_paint_annotations_to_pcd --config config/convert_deepen_to_t4_paint_sample.yaml

Notes for reviewer

for more information, see https://pre-commit.ci

ktro2828

@nanoshimarobot Thanks for your PR 🚀 I left some comments, please check this out.

perception_dataset/deepen/download_paint_annotations_to_pcd.py

for more information, see https://pre-commit.ci

perception_dataset/deepen/download_paint_annotations_to_pcd.py

* fix: remove unexpected normalization Signed-off-by: ktro2828 <[email protected]> * refactor: unpack `D` to specific variables Signed-off-by: ktro2828 <[email protected]> * fix: stack z values Signed-off-by: ktro2828 <[email protected]> * test: add unit testings for `view_points` Signed-off-by: ktro2828 <[email protected]> --------- Signed-off-by: ktro2828 <[email protected]>

* update README Signed-off-by: Shunsuke Miura <[email protected]> * remove unintended items from calibrated sensor data Signed-off-by: Shunsuke Miura <[email protected]> * update ego_pose Signed-off-by: Shunsuke Miura <[email protected]> * describe co-mlops format Signed-off-by: Shunsuke Miura <[email protected]> * fix typo Signed-off-by: Shunsuke Miura <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Shunsuke Miura <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

…4#132) * feat: remove `SensorChannel` and replace it with `str` Signed-off-by: ktro2828 <[email protected]> * docs: update documents Signed-off-by: ktro2828 <[email protected]> * fix: invalid method access Signed-off-by: ktro2828 <[email protected]> --------- Signed-off-by: ktro2828 <[email protected]>

Signed-off-by: Shunsuke Miura <[email protected]>

* fix decoding pointcloud2 msg Signed-off-by: Shunsuke Miura <[email protected]> * fix comments Signed-off-by: Shunsuke Miura <[email protected]> --------- Signed-off-by: Shunsuke Miura <[email protected]>

* fix decoding pointcloud2 msg Signed-off-by: Shunsuke Miura <[email protected]> * fix comments Signed-off-by: Shunsuke Miura <[email protected]> * support uint8 Signed-off-by: Shunsuke Miura <[email protected]> * remove ros2-numpy from poetry Signed-off-by: Shunsuke Miura <[email protected]> --------- Signed-off-by: Shunsuke Miura <[email protected]>

Signed-off-by: Shunsuke Miura <[email protected]>

* update pydantic version * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Shunsuke Miura <[email protected]>

updates: - [github.com/igorshubovych/markdownlint-cli: v0.39.0 → v0.41.0](igorshubovych/markdownlint-cli@v0.39.0...v0.41.0) - [github.com/psf/black: 24.4.2 → 24.8.0](psf/black@24.4.2...24.8.0) - [github.com/PyCQA/flake8: 7.0.0 → 7.1.1](PyCQA/flake8@7.0.0...7.1.1) Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

Signed-off-by: kminoda <[email protected]> Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]>

… worked) (tier4#145) Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

…n no label on TLR (tier4#140) * fix init value Signed-off-by: MasatoSaeki <[email protected]> * add delay_mseg value Signed-off-by: MasatoSaeki <[email protected]> * fix *_base in yaml Signed-off-by: MasatoSaeki <[email protected]> * add _convert_image for tlr (closed revert tier4#82) Signed-off-by: MasatoSaeki <[email protected]> * add skip method when we do not have label Signed-off-by: MasatoSaeki <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * delete no necessary parameter in tlr Signed-off-by: MasatoSaeki <[email protected]> * get back path in config Signed-off-by: MasatoSaeki <[email protected]> * change the way to initialize delay_msec in camera_sensors Signed-off-by: MasatoSaeki <[email protected]> * change comment Signed-off-by: MasatoSaeki <[email protected]> * add method if sensormode != no_lidar Signed-off-by: MasatoSaeki <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix data table Signed-off-by: MasatoSaeki <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: MasatoSaeki <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat(non_annotated_t4_tlr_to_deepen): add conversion tool Signed-off-by: kminoda <[email protected]> * update version Signed-off-by: kminoda <[email protected]> * remove camera_channels Signed-off-by: kminoda <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update tests Signed-off-by: kminoda <[email protected]> * update test Signed-off-by: kminoda <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * update Signed-off-by: kminoda <[email protected]> * dummy fix Signed-off-by: kminoda <[email protected]> * dummy commit Signed-off-by: kminoda <[email protected]> * update pyproject.toml Signed-off-by: kminoda <[email protected]> --------- Signed-off-by: kminoda <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

…er4#146) * fix: entity path of radar points Signed-off-by: ktro2828 <[email protected]> * feat: add support of saving recording result Signed-off-by: ktro2828 <[email protected]> * chore: fix rerun version to `0.17.0` Signed-off-by: ktro2828 <[email protected]> * feat: update to make directory if the corresponding directory does not exist Signed-off-by: ktro2828 <[email protected]> --------- Signed-off-by: ktro2828 <[email protected]>

Signed-off-by: ktro2828 <[email protected]>

* fix skip frame logic Signed-off-by: Shunsuke Miura <[email protected]> * increment the version number Signed-off-by: Shunsuke Miura <[email protected]> * refactor: extract get_camera_token into a separate function Signed-off-by: Shunsuke Miura <[email protected]> --------- Signed-off-by: Shunsuke Miura <[email protected]>

* Output topic drop error during initialization Signed-off-by: Shunsuke Miura <[email protected]> * Avoid out-of-bounds access in get_lidar_camera_synced_frame_info Signed-off-by: Shunsuke Miura <[email protected]> * Enhance image data handling to support CompressedImage format - Modify _generate_image_data to accept both np.ndarray and CompressedImage types - Add image_shape parameter to properly set image dimensions - Ensure correct saving of CompressedImage data Signed-off-by: Shunsuke Miura <[email protected]> * add RX2 constants Signed-off-by: Shunsuke Miura <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --------- Signed-off-by: Shunsuke Miura <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* chore: delete `t4-devkit` Signed-off-by: ktro2828 <[email protected]> * docs: update the documentation link of `t4-devkit` Signed-off-by: ktro2828 <[email protected]> --------- Signed-off-by: ktro2828 <[email protected]>

* add deepen import label script Signed-off-by: Shunsuke Miura <[email protected]> * fix bug Signed-off-by: Shunsuke Miura <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * remove unused code Signed-off-by: Shunsuke Miura <[email protected]> --------- Signed-off-by: Shunsuke Miura <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

* feat: add upload dataset script Signed-off-by: Shunsuke Miura <[email protected]> * formatting Signed-off-by: Shunsuke Miura <[email protected]> * fix config yaml Signed-off-by: Shunsuke Miura <[email protected]> * add outputting dataset ID list Signed-off-by: Shunsuke Miura <[email protected]> * Skip non-zip files when uploading datasets Signed-off-by: Shunsuke Miura <[email protected]> * remove unused code Signed-off-by: Shunsuke Miura <[email protected]> * add httpx to poetry Signed-off-by: Shunsuke Miura <[email protected]> --------- Signed-off-by: Shunsuke Miura <[email protected]>

* docs: add automatic_annotation information Signed-off-by: Shunsuke Miura <[email protected]> * fix description for automatic_annotation Signed-off-by: Shunsuke Miura <[email protected]> * update the description Signed-off-by: Shunsuke Miura <[email protected]> --------- Signed-off-by: Shunsuke Miura <[email protected]>

…ier4#156) * feat(rosbag2_to_non_annotated_t4): support image undistortion option Signed-off-by: Shunsuke Miura <[email protected]> * raise error when the camera_info is not found Signed-off-by: Shunsuke Miura <[email protected]> * overwrite distortion coefficient when applying undistortion Signed-off-by: Shunsuke Miura <[email protected]> * refactor image undistortion and camera info parsing Signed-off-by: Shunsuke Miura <[email protected]> * Fix return logic and error handling Signed-off-by: Shunsuke Miura <[email protected]> * Update perception_dataset/rosbag2/rosbag2_to_non_annotated_t4_converter.py Co-authored-by: kminoda <[email protected]> --------- Signed-off-by: Shunsuke Miura <[email protected]> Co-authored-by: kminoda <[email protected]>

* docs: update the description of ego_pose coordinate system Signed-off-by: Shunsuke Miura <[email protected]> * update Signed-off-by: Shunsuke Miura <[email protected]> --------- Signed-off-by: Shunsuke Miura <[email protected]>

…pport optional lidar index field (tier4#168) * enhance point_cloud2_to_array to support optional lidar index field Signed-off-by: Shunsuke Miura <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * add type hints Signed-off-by: Shunsuke Miura <[email protected]> --------- Signed-off-by: Shunsuke Miura <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>

…tion (tier4#164) * TODO: add deepen segmentation conversion Signed-off-by: ktro2828 <[email protected]> * feat: add support of converting deepen 2D segmentation annotation Signed-off-by: ktro2828 <[email protected]> * chore: update surface labels Signed-off-by: ktro2828 <[email protected]> * fix avoid to use `if cam_idx < num_cameras` Signed-off-by: ktro2828 <[email protected]> * fix: strip `sensor` instead of `sensor_` Signed-off-by: ktro2828 <[email protected]> * chore: update surface.yaml Signed-off-by: ktro2828 <[email protected]> * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * fix: use field if it has Signed-off-by: ktro2828 <[email protected]> * fix: resolve circular import Signed-off-by: ktro2828 <[email protected]> * fix: set default of to Signed-off-by: ktro2828 <[email protected]> * fix: update the condition of annotation types Signed-off-by: ktro2828 <[email protected]> * Update perception_dataset/deepen/segmentation/painting2d.py * Update config/label/surface.yaml * Update config/convert_deepen_to_t4_segmetation_painting_sample.yaml Co-authored-by: Shintaro Tomie <[email protected]> * Update config/convert_deepen_to_t4_segmetation_polygon_sample.yaml Co-authored-by: Shintaro Tomie <[email protected]> * chore: rename config files Signed-off-by: ktro2828 <[email protected]> * feat: update comparing sensor id and camera index Signed-off-by: ktro2828 <[email protected]> * feat: update surface labels Signed-off-by: ktro2828 <[email protected]> * feat: update comparing sensor index and camera index in painting Signed-off-by: ktro2828 <[email protected]> * fix: remove invalid operation Signed-off-by: ktro2828 <[email protected]> * Update perception_dataset/deepen/segmentation/polygon2d.py Co-authored-by: Shintaro Tomie <[email protected]> * Update perception_dataset/deepen/segmentation/polygon2d.py Co-authored-by: Shintaro Tomie <[email protected]> --------- Signed-off-by: ktro2828 <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Shintaro Tomie <[email protected]>

* feat: update record classes for CoMLOPs format Signed-off-by: ktro2828 <[email protected]> * ci: update test depends Signed-off-by: ktro2828 <[email protected]> * Update perception_dataset/ros2/oxts_msgs/ins_handler.py Co-authored-by: Shunsuke Miura <[email protected]> * feat: update acceleration coordinate system in base_link Signed-off-by: ktro2828 <[email protected]> * feat: update handling of velocity/omega/acceleration Signed-off-by: ktro2828 <[email protected]> * chore: remove unused tf-transformations Signed-off-by: ktro2828 <[email protected]> * ci: update to install pacmod3-msgs Signed-off-by: ktro2828 <[email protected]> * ci: update to install libboost-dev Signed-off-by: ktro2828 <[email protected]> * feat: set optional values to None by default Signed-off-by: ktro2828 <[email protected]> --------- Signed-off-by: ktro2828 <[email protected]> Co-authored-by: Shunsuke Miura <[email protected]>

Signed-off-by: Shunsuke Miura <[email protected]>

nanoshimarobot added 13 commits March 5, 2024 11:53

[update] download paint dataset

ee0b18f

[update] 1フレーム分だけ書き込みできた

46d82d5

[fix] annotation bug

a3e9fa6

[fix] decompressed labelの位置オフセット計算ミス

f5aaf3c

[update] paint annotation downloader

74742e9

Merge branch 'main' into feat/ground_seg_annotation

c298485

[remove] prev paint annotation downloader

3ad8679

[remove] unused paramater file

ecc3477

[update] config file for paint annotaion downloader

a785f28

[update] modified config for paint downloader

5bf2283

[refactor] download_paint_annotations

5ba44bf

Merge branch 'main' into feat/ground_seg_annotation

abfc575

[fix] gitignore, configs

154b6cd

nanoshimarobot requested a review from miursh May 24, 2024 03:33

pre-commit-ci bot and others added 2 commits May 24, 2024 03:34

[pre-commit.ci] auto fixes from pre-commit.com hooks

395533d

for more information, see https://pre-commit.ci

Merge branch 'main' into feat/ground_seg_annotation

dea76e4

nanoshimarobot mentioned this pull request Jun 10, 2024

feat: add ground_segmentation evaluator tier4/driving_log_replayer#479

Closed

3 tasks

Merge branch 'main' into feat/ground_seg_annotation

9c1d990

ktro2828 requested changes Jun 11, 2024

View reviewed changes

nanoshimarobot and others added 8 commits June 17, 2024 00:42

[update] add return type hint

57a4d33

[update] add checks for the existence of environment variables

54f0bce

[remove] unnecessary debug output

a7538d4

[update] exit if response contains HTTP status error

69ce89a

[update] add main()

f803a38

[pre-commit.ci] auto fixes from pre-commit.com hooks

58c4e78

for more information, see https://pre-commit.ci

Merge branch 'main' into feat/ground_seg_annotation

f674d9c

Merge branch 'main' into feat/ground_seg_annotation

a4eb462

ktro2828 reviewed Jun 23, 2024

View reviewed changes

perception_dataset/deepen/download_paint_annotations_to_pcd.py Outdated Show resolved Hide resolved

perception_dataset/deepen/download_paint_annotations_to_pcd.py Outdated Show resolved Hide resolved

nanoshimarobot added 2 commits June 24, 2024 10:38

[remove] unused module

701d23a

Merge branch 'main' into feat/ground_seg_annotation

f0f3e9a

ktro2828 and others added 30 commits November 24, 2024 16:02

release v1.0.13 (tier4#135)

2e4a298

Signed-off-by: Shunsuke Miura <[email protected]>

fix(rosbag2_to_non_annotated_t4): decoding pointcloud2 msg (tier4#137)

5822641

* fix decoding pointcloud2 msg Signed-off-by: Shunsuke Miura <[email protected]> * fix comments Signed-off-by: Shunsuke Miura <[email protected]> --------- Signed-off-by: Shunsuke Miura <[email protected]>

chore: fix push release tag workflow (tier4#143)

499ac09

Signed-off-by: Shunsuke Miura <[email protected]>

fix(utils): add cast for intensity (tier4#129)

3e4d23d

Signed-off-by: kminoda <[email protected]> Co-authored-by: Kenzo Lobos Tsunekawa <[email protected]>

chore: updated installation instructions (follows the ci/cd ones that…

56bf74e

… worked) (tier4#145) Signed-off-by: Kenzo Lobos-Tsunekawa <[email protected]>

chode: fix typo of occlusion (tier4#151)

b64d712

Signed-off-by: ktro2828 <[email protected]>

fix(t4-devkit): resolve rendering issues (tier4#155)

3065e32

chore: delete t4-devkit (tier4#160)

1016c4d

* chore: delete `t4-devkit` Signed-off-by: ktro2828 <[email protected]> * docs: update the documentation link of `t4-devkit` Signed-off-by: ktro2828 <[email protected]> --------- Signed-off-by: ktro2828 <[email protected]>

chore: bump to v1.0.16 (tier4#162)

54154e1

increment version number (tier4#170)

07d1ab0

Signed-off-by: Shunsuke Miura <[email protected]>

Merge branch 'main' into feat/ground_seg_annotation

29553ae

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat(deepen_to_t4): add paint label downloader #107

feat(deepen_to_t4): add paint label downloader #107

nanoshimarobot commented May 24, 2024

ktro2828 left a comment

feat(deepen_to_t4): add paint label downloader #107

Are you sure you want to change the base?

feat(deepen_to_t4): add paint label downloader #107

Conversation

nanoshimarobot commented May 24, 2024

Description

How to test

test data

test command

Notes for reviewer

ktro2828 left a comment

Choose a reason for hiding this comment