Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add more number output formats #180

Merged
merged 5 commits into from
May 27, 2024
Merged

Add more number output formats #180

merged 5 commits into from
May 27, 2024

Conversation

tiffany352
Copy link
Owner

@tiffany352 tiffany352 commented May 27, 2024

Adds to frac and to sci to explicitly force the use of these representations. Also adds to eng which behaves similar to the default behavior, except rounds to every third power of 10 instead of every power of 10. I might make the output format configurable and set the engineering one as the default in a future version.

While working on this I found a bug in the current version of rink. surveyfoot to digits is incorrect by 3 orders of magnitude. I fixed that in this PR.

Copy link

codecov bot commented May 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 76.79%. Comparing base (c0aadc4) to head (f4eea03).

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #180      +/-   ##
==========================================
+ Coverage   76.09%   76.79%   +0.70%     
==========================================
  Files          41       41              
  Lines        7383     7425      +42     
==========================================
+ Hits         5618     5702      +84     
+ Misses       1765     1723      -42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@tiffany352 tiffany352 marked this pull request as ready for review May 27, 2024 23:38
@tiffany352 tiffany352 merged commit fb1b58a into master May 27, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant