Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change Markdown to XEP-393 styling #104

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mimi89999
Copy link
Contributor

No description provided.

@hantu85
Copy link
Contributor

hantu85 commented Feb 23, 2021

Siskin IM (as well as Beagle IM) has support for Markdown and we are not willing to remove it. We could add XEP-0393 styling as a separate style that could be selected by the user (instead of Markdown) but as this pull request intentionally removes Markdown support (even without renaming files and functions) and converts it in XEP-0393, it cannot be accepted.

@mimi89999
Copy link
Contributor Author

I think that Markdown support shouldn't be kept because most clients (like Conversations, Dino, etc.) support only XEP-0393 and it will be bad if styling is not consistent across clients.

As for renaming files, I agree that they should be renamed and I can do that.

@hantu85
Copy link
Contributor

hantu85 commented Feb 24, 2021

And I think it should stay, as people (generally speaking, not just XMPP users) are more familiar with Markdown than with XEP-0393.

Also

Markdown support shouldn't be kept because most clients (like Conversations, Dino, etc.) support only XEP-0393

is not a reason to remove Markdown support but, at most, to add support for XEP-0393 without removal of XEP-0393.

In XMPP it is a freedom to choose which XEPs to support and which not to support. At this point, we do not support XEP-0393 but we do support Markdown.

As for XEP-0393, (as I've already mentioned on XMPP Summit when it was discussed), I think that an issue with this XEP is that it allows usage of XEP-0393 markup without marking stanza (or <body/> element) that text is actually styled and does not indicate what styling is used.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants