Delay requesting push notification authorization until an actual account exists #111
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for providing this patch. I've reviewed it and it would work almost as expected. The only issue could be when the account would log in faster than the user answered the question to grant permission for SiskinIM to show notifications. In this case, some notifications for messages received before the user granted permission could be lost. Most likely we will merge it to the next version of the SiskinIM. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a better user experience to not show an authorization prompt before the user has even added their account.
I submit my source code and allow Tigase to release the code as a part of Tigase's own software package under any license, either an open source or closed source.