Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General Url fetcher script for ms and ghaf #891

Merged
merged 1 commit into from
Nov 29, 2024
Merged

General Url fetcher script for ms and ghaf #891

merged 1 commit into from
Nov 29, 2024

Conversation

enesoztrk
Copy link
Contributor

@enesoztrk enesoztrk commented Nov 14, 2024 •
edited
Loading

Description of changes

Enhancing the ms-url-fetcher script to retrieve also proxy URLs from the Ghaf repository. The PAC file is also fetched periodically by the business VM from the same repository.

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

  • List all targets that this applies to:
  • Is this a new feature
    • List the test steps to verify:
      • Allowed Microsoft and Tii services/URLs must be opened in Trusted browser
  • If it is an improvement how does it impact existing functionality?

@enesoztrk enesoztrk temporarily deployed to internal-build-workflow November 14, 2024 14:37 — with GitHub Actions Inactive
@enesoztrk enesoztrk marked this pull request as ready for review November 18, 2024 08:04
@enesoztrk enesoztrk self-assigned this Nov 18, 2024
@enesoztrk enesoztrk temporarily deployed to internal-build-workflow November 26, 2024 20:51 — with GitHub Actions Inactive
@enesoztrk enesoztrk temporarily deployed to internal-build-workflow November 28, 2024 14:36 — with GitHub Actions Inactive
@enesoztrk enesoztrk temporarily deployed to internal-build-workflow November 29, 2024 00:39 — with GitHub Actions Inactive
@brianmcgillion brianmcgillion added the Needs Testing CI Team to pre-verify label Nov 29, 2024
@enesoztrk
Fetcher scripts for MS and Ghaf URLs
00ba543 
* A single script to fetch additional MS and Ghaf URLs in net-vm.
* Handling of PAC file by the fetcher script in business-vm.

Signed-off-by: Enes Öztürk <[email protected]>
@enesoztrk enesoztrk temporarily deployed to internal-build-workflow November 29, 2024 07:43 — with GitHub Actions Inactive
@milva-unikie
Copy link

Tested on Lenovo-X1 (full re-installation)

  • Microsoft services work in business-vm
  • TII Jira and Confluence work in business-vm
  • Other websites can not be accessed in business-vm
  • Test-automation passes

@milva-unikie milva-unikie added Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon and removed Needs Testing CI Team to pre-verify labels Nov 29, 2024
@brianmcgillion brianmcgillion merged commit da685e3 into tiiuae:main Nov 29, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mbssrc mbssrc mbssrc left review comments

@brianmcgillion brianmcgillion brianmcgillion approved these changes

Assignees

@enesoztrk enesoztrk

Labels
Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@enesoztrk @milva-unikie @brianmcgillion @mbssrc