Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ctrl panel bug report #926

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Ctrl panel bug report #926

wants to merge 1 commit into from
+100 −8

Conversation

Nerox9
Copy link
Contributor

@Nerox9 Nerox9 commented Dec 10, 2024 •
edited
Loading

Description of changes

MAC address shared with GUIVM.
Report page is added into settings of control panel.
Github configuration is added to submit a report. It has to be updated with valid info.
Bug report icon is not provided.

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

  • List all targets that this applies to:
    • Lenovo X1 x86_64
  • Is this a new feature
    • List the test steps to verify:
      • Run ghaf and launch the control panel.
      • Click to settings and select the report page from the bottom of the list.
      • Fill the report and submit. It prompts fail messages when any question is not answered or github configuration is not working.
      • The github message pops up if you try to submit first time. Copy the URI to browser and enter the given code to authenticate. You will not need for the next submission.
  • If it is an improvement how does it impact existing functionality?

@Nerox9 Nerox9 temporarily deployed to internal-build-workflow December 10, 2024 09:11 — with GitHub Actions Inactive
@Nerox9 Nerox9 requested a review from dmitry-erin December 10, 2024 09:11
@Nerox9 Nerox9 marked this pull request as draft December 10, 2024 09:11
@Nerox9 Nerox9 temporarily deployed to internal-build-workflow December 10, 2024 09:14 — with GitHub Actions Inactive
@Nerox9 Nerox9 temporarily deployed to internal-build-workflow December 11, 2024 14:05 — with GitHub Actions Inactive
@Nerox9 Nerox9 temporarily deployed to internal-build-workflow December 11, 2024 14:52 — with GitHub Actions Inactive
@Nerox9 Nerox9 changed the title Ctrl panel report Ctrl panel bug report Dec 11, 2024
@Nerox9 Nerox9 temporarily deployed to internal-build-workflow December 11, 2024 21:17 — with GitHub Actions Inactive
@Nerox9 Nerox9 marked this pull request as ready for review December 11, 2024 21:28
@Nerox9 Nerox9 requested review from nesteroff and vadika December 11, 2024 21:29
@Nerox9 Nerox9 marked this pull request as draft December 11, 2024 21:47
@Nerox9 Nerox9 temporarily deployed to internal-build-workflow December 12, 2024 09:09 — with GitHub Actions Inactive
@Nerox9 Nerox9 marked this pull request as ready for review December 12, 2024 09:09
@Nerox9 Nerox9 added the Needs Testing CI Team to pre-verify label Dec 12, 2024
@Nerox9 Nerox9 temporarily deployed to internal-build-workflow December 12, 2024 10:39 — with GitHub Actions Inactive
nesteroff
nesteroff reviewed Dec 12, 2024
View reviewed changes
@milva-unikie milva-unikie removed the Needs Testing CI Team to pre-verify label Dec 12, 2024
@Nerox9 Nerox9 temporarily deployed to internal-build-workflow December 13, 2024 10:43 — with GitHub Actions Inactive
@Nerox9 Nerox9 requested a review from nesteroff December 13, 2024 10:46
@Nerox9 Nerox9 temporarily deployed to internal-build-workflow December 13, 2024 11:14 — with GitHub Actions Inactive
@Nerox9 Nerox9 temporarily deployed to internal-build-workflow December 13, 2024 11:28 — with GitHub Actions Inactive
@Nerox9 Nerox9 added the Needs Testing CI Team to pre-verify label Dec 13, 2024
@milva-unikie

This comment was marked as outdated.

Sign in to view
@milva-unikie milva-unikie added bug on Lenovo X1 Carbon Issues found on Lenovo X1 Carbon while checking this PR and removed Needs Testing CI Team to pre-verify labels Dec 17, 2024
@Nerox9 Nerox9 added Needs Testing CI Team to pre-verify bug on Lenovo X1 Carbon Issues found on Lenovo X1 Carbon while checking this PR and removed bug on Lenovo X1 Carbon Issues found on Lenovo X1 Carbon while checking this PR Needs Testing CI Team to pre-verify labels Dec 17, 2024
vadika
vadika reviewed Jan 22, 2025
View reviewed changes
Copy link
Contributor

@vadika vadika left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any progress there?

@Nerox9
Copy link
Contributor Author

Nerox9 commented Jan 23, 2025

Any progress there?

I have created a PR . When it is merged I will change the control panel commit reference and something else if needed.

@vadika
Copy link
Contributor

vadika commented Jan 27, 2025

Any progress there?

I have created a PR . When it is merged I will change the control panel commit reference and something else if needed.

Don't see any reviewers in mentinoned PR -- looks like calling them will speed up the merge?

@Nerox9 Nerox9 force-pushed the ctrl-panel-report branch from e52b0a0 to 1823500 Compare January 29, 2025 10:46
@Nerox9 Nerox9 temporarily deployed to internal-build-workflow January 29, 2025 10:46 — with GitHub Actions Inactive
@Nerox9 Nerox9 temporarily deployed to internal-build-workflow February 17, 2025 12:25 — with GitHub Actions Inactive
@Nerox9 Nerox9 temporarily deployed to internal-build-workflow February 19, 2025 13:29 — with GitHub Actions Inactive
@Nerox9 Nerox9 added Needs Testing CI Team to pre-verify and removed bug on Lenovo X1 Carbon Issues found on Lenovo X1 Carbon while checking this PR labels Feb 19, 2025
@Nerox9 Nerox9 temporarily deployed to internal-build-workflow February 19, 2025 13:32 — with GitHub Actions Inactive
@milva-unikie
Copy link

milva-unikie commented Feb 21, 2025 •
edited
Loading

Tested on Lenovo-X1 (nixos-rebuild switch)

There is still an open ghaf-ctrl-panel PR that needs to be merged and updated in the flake before this can be merged. tiiuae/ghaf-ctrl-panel#8

I updated the ctrl-panel flake to point to that branch for testing.

Once the flake is updated this is good to go in!

@milva-unikie milva-unikie removed the Needs Testing CI Team to pre-verify label Feb 21, 2025
@Nerox9
Ctrl-Panel: Add Bug Report
e9d91fb 
Add report page into control panel

MAC address shared with GUIVM
Bug report page is added into settings of control panel
Github authentication is added to submit a report

Signed-off-by: Berk Arslan <[email protected]>
@Nerox9 Nerox9 temporarily deployed to internal-build-workflow February 24, 2025 08:44 — with GitHub Actions Inactive
@milva-unikie
Copy link

Tested on Lenovo-X1 (nixos-rebuild switch)

  • Works now!

@milva-unikie milva-unikie added the Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon label Feb 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vadika vadika vadika approved these changes

@dmitry-erin dmitry-erin Awaiting requested review from dmitry-erin

@brianmcgillion brianmcgillion Awaiting requested review from brianmcgillion

@nesteroff nesteroff Awaiting requested review from nesteroff

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@Nerox9 @milva-unikie @vadika @nesteroff