Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gtklock-userinfo-module: Add custom Icon path #928

Merged
merged 1 commit into from
Dec 11, 2024

Conversation

vunnyso
Copy link
Contributor

@vunnyso vunnyso commented Dec 10, 2024

Description of changes

With this patch user can set custom image when the system is locked for identification purpose.

Checklist for things done

  • Summary of the proposed changes in the PR description
  • More detailed description in the commit message(s)
  • Commits are squashed into relevant entities - avoid a lot of minimal dev time commits in the PR
  • Contribution guidelines followed
  • Ghaf documentation updated with the commit - https://tiiuae.github.io/ghaf/
  • PR linked to architecture documentation and requirement(s) (ticket id)
  • Test procedure described (or includes tests). Select one or more:
    • Tested on Lenovo X1 x86_64
    • Tested on Jetson Orin NX or AGX aarch64
    • Tested on Polarfire riscv64
  • Author has run make-checks and it passes
  • All automatic Github Action checks pass - see actions
  • Author has added reviewers and removed PR draft status
  • Change requires full re-installation
  • Change can be updated with nixos-rebuild ... switch

Instructions for Testing

  • List all targets that this applies to:
  • Is this a new feature
    • List the test steps to verify:
  • If it is an improvement how does it impact existing functionality?
    User Image can be set when system is locked

Expected output when image is kept under

[ghaf@gui-vm:~]$ ls /home/ghaf/Pictures/.face (any jpg file is fine, recommended to use circular image)

image

With this patch user can set custom image when the
system is locked for identification purpose.

Signed-off-by: Vunny Sodhi <[email protected]>
@vunnyso vunnyso temporarily deployed to internal-build-workflow December 10, 2024 14:19 — with GitHub Actions Inactive
@vunnyso vunnyso requested review from humaidq-tii, unbel13ver and brianmcgillion and removed request for humaidq-tii December 10, 2024 14:20
@vunnyso vunnyso requested a review from kajusnau December 11, 2024 07:30
@vunnyso vunnyso added the Needs Testing CI Team to pre-verify label Dec 11, 2024
Copy link
Contributor

@kajusnau kajusnau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work!

It would be nice to have a more convenient way to update the user profile picture in the future, maybe through the control panel.

@milva-unikie
Copy link

Tested on Lenovo-X1 (nixos-rebuild switch)

  • Setting an image works
  • Non-circular images might get cropped a bit weirdly but they also work
  • Image is preserved between boots
  • Test-automation passes

@milva-unikie milva-unikie added Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon and removed Needs Testing CI Team to pre-verify labels Dec 11, 2024
@brianmcgillion brianmcgillion merged commit 6ac9d7e into tiiuae:main Dec 11, 2024
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Tested on Lenovo X1 Carbon This PR has been tested on Lenovo X1 Carbon
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants