Mpfs handle pending plic irqs #359
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jlaitine
force-pushed
the
mpfs_handle_pending_plic_irqs
branch
2 times, most recently
from
c437f19 to
cf70c6c
Compare
pussuw
reviewed
Feb 19, 2025
arch/risc-v/src/mpfs/mpfs_plic.c
Outdated
|
|
||
| /* Return the irq priority to 1 */ | ||
|
|
||
| putreg32(1, MPFS_PLIC_PRIORITY + (4 * extirq)); |
There was a problem hiding this comment.
Just a suggestion, make the two interrupt priority levels into define macros:
#define PLIC_PRIO_DEFAULT 1
#define PLIC_PRIO_MAX 0xfffffffff
And so forth ? To get rid of the magic number ?
pussuw
reviewed
Feb 19, 2025
arch/risc-v/src/mpfs/mpfs_plic.c
Outdated
|
|
||
| void mpfs_plic_clear_and_enable_irq(int extirq) | ||
| { | ||
| int hartid = riscv_mhartid(); |
There was a problem hiding this comment.
Please use up_cpu_index, to make it easier to upstream this. riscv_mhartid has been deprecated.
jlaitine
force-pushed
the
mpfs_handle_pending_plic_irqs
branch
from
cf70c6c to
a2ec8dc
Compare
….c and handle pending interrupts - Move PLIC interrupt enable and disable functions into mpfs_plic.c - When enabling interrupts, always clear pending interrupt A pending interrupt would trigger immediately when enabling the interrupt source, but this is not expected. The interrupt source is level sensitive, so it should only trigger if the source is active at the time when it is enabled. Not if it was active sometime in the past. Signed-off-by: Jukka Laitinen <[email protected]>
jlaitine
force-pushed
the
mpfs_handle_pending_plic_irqs
branch
from
a2ec8dc to
f3ae36b
Compare
pussuw
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.