arch/risc-v/src/mpfs/mpfs_plic.c: Fix error introduced by earlier commit which added spinlocks #361
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pussuw
approved these changes
Feb 21, 2025
I was planning to just upstream one patch with all 3, where also this is squashed - i.e. creae a confilict. Will add [REMOVEME] to this one |
jlaitine
force-pushed
the
fix_deadlock_in_mpfs_plic
branch
from
df8145e to
be636ae
Compare
pussuw
approved these changes
Feb 21, 2025
pussuw
approved these changes
Feb 21, 2025
…earlier commit which added spinlocks Signed-off-by: Jukka Laitinen <[email protected]>
jlaitine
force-pushed
the
fix_deadlock_in_mpfs_plic
branch
from
be636ae to
d5f52b6
Compare
|
Only changed the commit message |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This issue is only present in our current version of NuttX, and is related to broken "global" spinlock "spin_lock_irqsave(NULL)". This is no longer present in upstream NuttX.
Still, change modifyreg32 calls to putreg32(getreg32...)... as we are anyway inside our own spinlock so calling modifyreg32 is useless in these cases - fixing the deadlocking issue in SMP with this older NuttX version at the same.