New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: provide a API for users to process log message in pnpm-sync-lib #15

Merged

g-chao merged 3 commits into main from chao/refactor-logging

Feb 28, 2024

Collaborator

g-chao commented Feb 28, 2024 •

edited

Loading

Summary

This PR is to address #14

Currently, the pnpm-sync-lib will console.log messages directly.

This brings inconvenience for users who want to customize the log message when integrating to their own Monorepo management tools.

Details

Refactor API interfaces for pnpmSyncCopyAsync and pnpmSyncPrepareAsync in pnpm-sync-lib, adds a logMessageCallback for users to customize the log behavior
Refactor pnpm-sync to use new API interfaces


          refactor: provide logMessageCallback

a035519

g-chao requested a review from octogonz

February 28, 2024 00:02

octogonz reviewed

View reviewed changes

packages/pnpm-sync-lib/etc/pnpm-sync-lib.api.md Outdated Show resolved Hide resolved

octogonz reviewed

View reviewed changes

packages/pnpm-sync-lib/etc/pnpm-sync-lib.api.md Outdated Show resolved Hide resolved

octogonz reviewed

View reviewed changes

packages/pnpm-sync-lib/etc/pnpm-sync-lib.api.md Outdated Show resolved Hide resolved

octogonz reviewed

View reviewed changes

packages/pnpm-sync/src/start.ts Outdated Show resolved Hide resolved


          fix: refeactor log message interfaces

cf10616

octogonz reviewed

View reviewed changes

packages/pnpm-sync-lib/src/interfaces.ts Show resolved Hide resolved

octogonz approved these changes

View reviewed changes


          fix: change enum wordings

f2b7fe8

g-chao merged commit 89c55ba into main

1 check passed

g-chao deleted the chao/refactor-logging branch

February 28, 2024 22:52

g-chao restored the chao/refactor-logging branch

March 1, 2024 00:08

g-chao mentioned this pull request

[rush-lib] Use pnpm-sync-lib logging APIs to customize the log message for pnpm-sync operations. microsoft/rushstack#4594

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet