Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat quicker selection #93

Merged
merged 5 commits into from
Oct 24, 2024
Merged

Feat quicker selection #93

merged 5 commits into from
Oct 24, 2024

Conversation

chengcyber
Copy link
Member

@chengcyber chengcyber commented Oct 22, 2024

Basic Checks

Have you run rush change for this change?

  • Yes
  • No

If No, please run rush change before, this is necessary.

If adding a new feature, the PR's description includes:

  • Reason for adding this feature
  • How to use
  • A basic example

Does this PR introduce a breaking change? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

Summary

Introduce a quicker algorithm if applicable.

Detail

BEFORE: running sparo checkout --to <package_name> always internally invoking rush list to get a full functionality of getting target folders by selection parameters from Rush.js.

AFTER: if running sparo checkout --to/--from with named package only, a new algorithm will be opted-in to avoid the time to preparation the local Rush.js. That says that the new algorithm doesn't need to bootstrap local Rush.js which save some time.

Some cases:

sparo checkout --to foo --from bar opt in
sparo checkout --to subspace:subspace_name fallback to rush list
sparo checkout --to tag:tag_name fallback to rush list

How to test it

Local

@chengcyber chengcyber force-pushed the feat-quicker-selection branch from 9d60c20 to 97adbfc Compare October 23, 2024 20:49
@jzhang026
Copy link
Contributor

I see. we implemented a slim version of RushConfiguration. then based on user inputs, get all the dependents packages. so that we get rid of rush list

@EscapeB EscapeB enabled auto-merge October 24, 2024 10:42
@EscapeB EscapeB disabled auto-merge October 24, 2024 10:43
@chengcyber chengcyber merged commit c7f55da into main Oct 24, 2024
3 checks passed
@chengcyber chengcyber deleted the feat-quicker-selection branch October 24, 2024 19:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants