-
Notifications
You must be signed in to change notification settings - Fork 233
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add code lint #10
add code lint #10
Conversation
Signed-off-by: disksing <[email protected]>
@@ -3,3 +3,7 @@ default: | |||
|
|||
test: | |||
GO111MODULE=on go test ./... | |||
|
|||
check: | |||
GO111MODULE=off go get golang.org/x/lint/golint |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
How about using golangci-lint
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe later? I want it to work first and then improve.
Signed-off-by: disksing <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
# Conflicts: # rawkv/rawkv.go
* add code lint Signed-off-by: disksing <[email protected]>
Signed-off-by: zyguan <[email protected]> Co-authored-by: zyguan <[email protected]>
Signed-off-by: disksing [email protected]