Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use context everywhere #23

Merged
merged 5 commits into from
Jun 19, 2019
Merged

Use context everywhere #23

merged 5 commits into from
Jun 19, 2019

Conversation

disksing
Copy link
Collaborator

Fixes #21

disksing added 5 commits June 17, 2019 18:32
Signed-off-by: disksing <[email protected]>
Signed-off-by: disksing <[email protected]>
Signed-off-by: disksing <[email protected]>
Signed-off-by: disksing <[email protected]>
@disksing disksing requested a review from rleungx June 17, 2019 12:11
@disksing
Copy link
Collaborator Author

cc @shafreeck

Copy link
Member

@rleungx rleungx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@disksing disksing merged commit 77a15fc into tikv:master Jun 19, 2019
@disksing disksing deleted the cancel branch June 19, 2019 17:18
daimashusheng pushed a commit to daimashusheng/client-go that referenced this pull request Sep 2, 2021
* rawkv

Signed-off-by: disksing <[email protected]>

* txnkv wip

Signed-off-by: disksing <[email protected]>

* txnkv wip

Signed-off-by: disksing <[email protected]>

* txnkv update get & batchGet

Signed-off-by: disksing <[email protected]>

* txnkv iterators

Signed-off-by: disksing <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

All methods that do IO should take context.Context as arguments
2 participants