This repository was archived by the owner on Aug 28, 2021. It is now read-only.
validator: implement client stub to interatct with proxy server #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: disksing <[email protected]>
This was referenced Apr 11, 2019
Merged
rleungx
reviewed
Apr 23, 2019
| } | ||
|
|
||
| // Scan queries continuous kv pairs in range [startKey, endKey), up to limit pairs. | ||
| func (c *RawClientStub) Scan(startKey, endKey []byte, limit int) ([][]byte, [][]byte, error) { |
There was a problem hiding this comment.
Yes. Plan to do it when resolving #6
rleungx
reviewed
Apr 24, 2019
| client: http.Client{Timeout: time.Second * 10}, | ||
| proxyServer: strings.TrimSuffix(proxyServer, "/"), | ||
| } | ||
| res, err := client.send("/rawkv/client/new", &RawRequest{PDAddrs: pdServers}) |
There was a problem hiding this comment.
How about using a prefix variable?
There was a problem hiding this comment.
I think this way is more readable to understand the format of the URI.
|
|
||
| // Close closes the client and releases resources in proxy server. | ||
| func (c *RawClientStub) Close() error { | ||
| _, err := c.send(fmt.Sprintf("/rawkv/client/%s/close", c.id), &RawRequest{}) |
There was a problem hiding this comment.
maybe we can directly use + here?
There was a problem hiding this comment.
I think this way is more readable to understand the format of the URI.
There was a problem hiding this comment.
fmt.Sprintf relies on the reflection which is not elegant I think.
There was a problem hiding this comment.
Why reflection is not elegant... For the validator, performance is not important, what matters is correctness and readability.
Signed-off-by: disksing <[email protected]>
rleungx
approved these changes
Apr 25, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The client stub will look like a RawKVClient / TxnKVClient, but internally send messages to the proxy server.
Signed-off-by: disksing [email protected]