Following V2 Specification

[benoit9126]

Implement the remaining part of #42.

@rmarianski The current version of the package solves my problem of protobuf dependencies (with or without this PR). I just had some time.
I don't see what else I could add for now. Maybe #107.
When do you plan to make a release (including #124) ?

[coveralls]

Coverage: ?%. Remained the same when pulling 0921618 on benoit9126:v2-spec into 5249a23 on tilezen:master.

[coveralls]

Coverage: 78.292% (+0.3%) from 78.038% when pulling 0921618 on benoit9126:v2-spec into 5249a23 on tilezen:master.

[rmarianski]

code looks good, thanks for the pr 🙇 Some comments

Implement the remaining part of #42.

was there still an outstanding issue related to line to's? Was looking at this comment.

I don't see what else I could add for now. Maybe #107.
When do you plan to make a release (including #124) ?

pr's always appreciated :)

Since this would be a major bump, if there's anything that would constitute a breaking change, it'd be nice to include. I scanned through the open issues, and it seems to me like #107 would be the only candidate anyway though. Does that sound low effort?

[benoit9126]

Yes, there is this "lineTo" command which must have movements. I am not sure, but I think that thanks to the lines 70-71 here, if there are no coordinates after the "lineTo", nothing is added in the tile. I don't know if it is sufficient to ensure the request of the comment of #42.

pr's always appreciated :)

🚀

For #107, there are interesting details in OGR documentation: here.

• It seems that the conversion of the provided coordinates into EPSG:4326 is required. pyproj will become a dependency. It may also be time to implement when decoding ,how to convert coordinates back to EPSG:4326. #110 if pyproj is added.
• Moreover, I will need some help on the polygon decoding to ensure the specifications are respected.
• I think that bbox fields can be ignored in a first implementation.

[rmarianski]

but I think that thanks to the lines 70-71 here, if there are no coordinates after the "lineTo", nothing is added in the tile.

Thanks for the reference. I double checked the code, and I'm convinced of that too 👍