Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Encode version 1 in layers #47

Merged
merged 1 commit into from
Apr 15, 2016
Merged

Encode version 1 in layers #47

merged 1 commit into from
Apr 15, 2016

Conversation

rmarianski
Copy link
Member

Connects to #42

@zerebubuth could you review please?

@coveralls
Copy link

Coverage Status

Coverage remained the same at 93.131% when pulling 53ab707 on encode-version-1 into 773dbfd on master.

@rmarianski
Copy link
Member Author

Thinking about this a little bit more, could it have consequences in tangram wrt the multipolygon winding order changes?

@zerebubuth
Copy link
Member

As far as I can tell from Tangram's decoder, it isn't checking the version, so I think we're safe to "downgrade" to v1 for the moment.

@zerebubuth
Copy link
Member

👍

@rmarianski
Copy link
Member Author

Cool. I forgot that tangram itself was handling decoding multipolygons.

@rmarianski rmarianski merged commit db05dcf into master Apr 15, 2016
@rmarianski rmarianski deleted the encode-version-1 branch April 15, 2016 14:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants